Date: Wed, 6 Sep 2023 07:34:15 +0200 From: Matthias Apitz <guru@unixarea.de> To: Warner Losh <imp@bsdimp.com> Cc: sgk@troutmask.apl.washington.edu, Michael Gmelin <grembo@freebsd.org>, Alexander Motin <mav@freebsd.org>, FreeBSD Current <freebsd-current@freebsd.org> Subject: Re: 14.0-CURRENT boots fine but keyboard does not work Message-ID: <ZPgPV4WD7UdZavDV@c720-r368166> In-Reply-To: <CANCZdfrQH033NCo-pwZ3MM2cMDyCXU-AKxKv3UB7oqedP5402A@mail.gmail.com> References: <ZPYVKL74wlue%2BOuu@c720-r368166> <58E9D0C9-747F-4DEB-9DC7-5A2E8C54EABF@freebsd.org> <CANCZdfre5vW%2BQinsUXuwrROS_70iR%2Bpyz9Y7BWcWXxYuZEakxQ@mail.gmail.com> <ZPbG8qXfoWIHvMW3@c720-r368166> <CANCZdfow6imSy%2BxrCsrt0wSFfnWRLWtj7tuV6TO0Ci0oP1eRAQ@mail.gmail.com> <ZPdr57eg92ykqGg1@c720-r368166> <CANCZdfpUTBtSQKQSqXyw%2BcWMSsyKSaMsUCwDyLM2nNhGiS1gvA@mail.gmail.com> <ZPeOEtAdIMFXXlmC@troutmask.apl.washington.edu> <CANCZdfrQH033NCo-pwZ3MM2cMDyCXU-AKxKv3UB7oqedP5402A@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--wqmAerRmXjsN2nMD Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit El día martes, septiembre 05, 2023 a las 03:24:30p. m. -0600, Warner Losh escribió: > On Tue, Sep 5, 2023 at 2:22 PM Steve Kargl <sgk@troutmask.apl.washington.edu> > wrote: > > > On Tue, Sep 05, 2023 at 01:29:34PM -0600, Warner Losh wrote: > > > + /* > > > + * Some Chromebooks don't confirm to the google comment above so do > > the > > > > s/confirm/conform ? > > > > > > > + * Chromebook workaround for all <= 2018 coreboot systems that have > > a > > > + * 'blank' version. At least once Acer "Peppy" chromebook has this > > > issue, > > > > s/once/one ? > > > > Yes. Thanks! Dashed off the comment in a hurry since I wanted to get the > patch out > there in a hurry... But that was kinda sloppy of me.. fixed. I've had to apply the patch manually (attached as context diff). With this the keyboard works also fine. Thanks matthias -- Matthias Apitz, ✉ guru@unixarea.de, http://www.unixarea.de/ +49-176-38902045 Public GnuPG key: http://www.unixarea.de/key.pub --wqmAerRmXjsN2nMD Content-Type: text/x-diff; charset=utf-8 Content-Disposition: attachment; filename="atkbdc.c.diff" *** /usr/src/sys/dev/atkbdc/atkbdc.c.ORIG Sat Aug 5 12:50:44 2023 --- /usr/src/sys/dev/atkbdc/atkbdc.c Wed Sep 6 07:08:49 2023 *************** *** 149,154 **** --- 149,155 ---- char *maker = kern_getenv("smbios.system.maker"); char *product = kern_getenv("smbios.system.product"); char *version = kern_getenv("smbios.bios.version"); + char *reldate = kern_getenv("smbios.bios.reldate"); for (i = 0; i < nitems(quirks); i++) if (QUIRK_STR_EQUAL(quirks[i].bios_vendor, bios_vendor) && *************** *** 156,161 **** --- 157,173 ---- QUIRK_STR_EQUAL(quirks[i].product, product) && QUIRK_STR_MATCH(quirks[i].version, version)) return (quirks[i].quirk); + + /* + * Some Chromebooks don't conform to the google comment above so do the + * Chromebook workaround for all <= 2018 coreboot systems that have a + * 'blank' version. At least one Acer "Peppy" chromebook has this issue, + * with a reldate of 08/13/2014. + */ + if (QUIRK_STR_EQUAL("coreboot", bios_vendor) && + (version != NULL && *version == ' ') && + (reldate != NULL && strlen(reldate) >= 10 && strcmp(reldate + 6, "2018") <= 0)) + return (CHROMEBOOK_WORKAROUND); return (0); } --wqmAerRmXjsN2nMD--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ZPgPV4WD7UdZavDV>