From owner-cvs-all@FreeBSD.ORG Sun Nov 20 08:08:50 2005 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A626416A41F; Sun, 20 Nov 2005 08:08:50 +0000 (GMT) (envelope-from grog@lemis.com) Received: from ext-gw.lemis.com (ext-gw.lemis.com [150.101.14.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id E9D0643D46; Sun, 20 Nov 2005 08:08:49 +0000 (GMT) (envelope-from grog@lemis.com) Received: from wantadilla.lemis.com (wantadilla.lemis.com [192.109.197.135]) by ext-gw.lemis.com (Postfix) with ESMTP id 19A30131D46; Sun, 20 Nov 2005 18:38:49 +1030 (CST) Received: from eucla.lemis.com (wantadilla.lemis.com [192.109.197.135]) by wantadilla.lemis.com (Postfix) with ESMTP id 8490D84AC7; Sun, 20 Nov 2005 18:38:48 +1030 (CST) Received: by eucla.lemis.com (Postfix, from userid 1004) id 8250486C9F; Sun, 20 Nov 2005 09:08:50 +0100 (CET) Date: Sun, 20 Nov 2005 09:08:50 +0100 From: Greg 'groggy' Lehey To: Colin Percival Message-ID: <20051120080850.GD856@eucla.lemis.com> References: <200511200050.jAK0oUbB059874@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200511200050.jAK0oUbB059874@repoman.freebsd.org> User-Agent: Mutt/1.4.2.1i Organization: The FreeBSD Project Phone: +61-8-8388-8286 Fax: +61-8-8388-8725 Mobile: +61-418-838-708 WWW-Home-Page: http://www.FreeBSD.org/ X-PGP-Fingerprint: 9A1B 8202 BCCE B846 F92F 09AC 22E6 F290 507A 4223 Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/portsnap/make_index make_index.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Nov 2005 08:08:50 -0000 On Sunday, 20 November 2005 at 0:50:30 +0000, Colin Percival wrote: > cperciva 2005-11-20 00:50:30 UTC > > FreeBSD src repository > > Modified files: > usr.sbin/portsnap/make_index make_index.c > Log: > An empty file does not have a positive number of lines. Yes it does. It's 0, not -0. > Make sure that the number of lines read is non-zero before in > order to avoid dumping core. This is a different (and presumably correct) test. Greg -- See complete headers for address and phone numbers