From owner-cvs-src@FreeBSD.ORG Sun Aug 20 18:55:52 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C8CC816A4DD; Sun, 20 Aug 2006 18:55:52 +0000 (UTC) (envelope-from keramida@FreeBSD.org) Received: from igloo.linux.gr (igloo.linux.gr [62.1.205.36]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0399343D45; Sun, 20 Aug 2006 18:55:51 +0000 (GMT) (envelope-from keramida@FreeBSD.org) Received: from gothmog.pc (host5.bedc.ondsl.gr [62.103.39.229]) (authenticated bits=128) by igloo.linux.gr (8.13.7/8.13.7/Debian-2) with ESMTP id k7KItJtd021298 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sun, 20 Aug 2006 21:55:20 +0300 Received: from gothmog.pc (gothmog [127.0.0.1]) by gothmog.pc (8.13.7/8.13.7) with ESMTP id k7KItTWJ012063; Sun, 20 Aug 2006 21:55:29 +0300 (EEST) (envelope-from keramida@FreeBSD.org) Received: (from giorgos@localhost) by gothmog.pc (8.13.7/8.13.7/Submit) id k7KItPMS012062; Sun, 20 Aug 2006 21:55:25 +0300 (EEST) (envelope-from keramida@FreeBSD.org) Date: Sun, 20 Aug 2006 21:55:25 +0300 From: Giorgos Keramidas To: Yar Tikhiy Message-ID: <20060820185525.GA12000@gothmog.pc> References: <200608181210.k7ICAIme084410@repoman.freebsd.org> <86ejvet9m6.fsf@xps.des.no> <20060818143310.GA14203@comp.chem.msu.su> <20060818143508.GA2545@lor.one-eyed-alien.net> <20060818153744.GA14726@comp.chem.msu.su> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060818153744.GA14726@comp.chem.msu.su> X-Hellug-MailScanner: Found to be clean X-Hellug-MailScanner-SpamCheck: not spam, SpamAssassin (score=-3.32, required 5, autolearn=not spam, AWL -0.72, BAYES_00 -2.60, UNPARSEABLE_RELAY 0.00) X-Hellug-MailScanner-From: keramida@freebsd.org X-Spam-Status: No Cc: Brooks Davis , Dag-Erling Sm?rgrav , src-committers@FreeBSD.org, cvs-all@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/etc rc.subr X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Aug 2006 18:55:52 -0000 On 2006-08-18 19:37, Yar Tikhiy wrote: > On Fri, Aug 18, 2006 at 09:35:08AM -0500, Brooks Davis wrote: > > On Fri, Aug 18, 2006 at 06:33:11PM +0400, Yar Tikhiy wrote: > > > On Fri, Aug 18, 2006 at 04:13:37PM +0200, Dag-Erling Sm?rgrav wrote: > > > > Yar Tikhiy writes: > > > > > Log: > > > > > The ps(1) command is unfriendly to scripts by default because > > > > > it limits the width of its output to the value of $COLUMNS, or > > > > > what TIOCGWINSZ reports, or 79 columns. We should specify -ww > > > > > to ps(1) so that it removes the limit and prints lines in full. > > > > > Otherwise very long command pathnames could be mishandled, e.g., > > > > > by _find_processes(). > > > > > > > > or perhaps _find_processes() should use pgrep(1) instead of ps(1). > > > > > > I considered that but had to stick to ps(1) because pgrep was in > > > /usr/bin while ps was in /bin. The use of /usr/bin tools should > > > be very limited in rc.subr(8). OTOH, pgrep uses /lib libs only, > > > which makes it possible to transfer pgrep+pkill to /bin if we can > > > stand the growth of / by some 50 kbytes. > > > > I think that's appropriate since pgrep is such an obvious fit for this > > sort of thing. I think we'll want to consider compatability symlinks > > due to existing hardcoded paths in scripts. > > Creating the compat symlinks should be as easy as adding the following > lines to the Makefile: > > SYMLINKS= ${BINDIR}/pgrep /usr/bin/pgrep > SYMLINKS+= ${BINDIR}/pkill /usr/bin/pkill Hmmm. Shouldn't this be using ${DESTDIR} in the right-hand paths?