From owner-cvs-all Mon Apr 1 16:35:22 2002 Delivered-To: cvs-all@freebsd.org Received: from dragon.nuxi.com (trang.nuxi.com [66.92.13.169]) by hub.freebsd.org (Postfix) with ESMTP id 7DF0F37B41A; Mon, 1 Apr 2002 16:35:11 -0800 (PST) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by dragon.nuxi.com (8.12.2/8.12.2) with ESMTP id g320ZAYm019169; Mon, 1 Apr 2002 16:35:10 -0800 (PST) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.12.2/8.12.2/Submit) id g320XtsP097192; Mon, 1 Apr 2002 16:33:55 -0800 (PST) Date: Mon, 1 Apr 2002 16:33:55 -0800 From: "David O'Brien" To: Matt Dillon Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/i386 critical.c src/sys/i386/include cpufunc.h critical.h src/sys/i386/isa apic_vector.s icu_vector.s src/sys/kern kern_fork.c kern_proc.c kern_switch.c src/sys/alpha/alpha critical.c src/sys/alpha/include cpufunc.h ... Message-ID: <20020401163355.B38457@dragon.nuxi.com> Reply-To: obrien@FreeBSD.org References: <200204012351.g31NpO890339@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <200204012351.g31NpO890339@freefall.freebsd.org>; from dillon@FreeBSD.org on Mon, Apr 01, 2002 at 03:51:24PM -0800 X-Operating-System: FreeBSD 5.0-CURRENT Organization: The NUXI BSD group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Mon, Apr 01, 2002 at 03:51:24PM -0800, Matt Dillon wrote: > Backout and re-apply improperly comitted syntactical cleanups made to files > that were still under active development. Backout improperly comitted program > structure changes that moved localized declarations to the top of two > procedures. Why are the "program structure changes that moved localized declarations to the top of two procedures", improper? > Note: In general, developers should not gratuitously move declarations out > of sub-blocks. They are where they are for reasons of structure, grouping, > readability, compiler-localizability, and to avoid developer-introduced bugs > similar to several found in recent years in the VFS and VM code. style(9) says otherwise -- code is more readable when all variables are declared at the top of a function. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message