From owner-svn-src-head@freebsd.org  Tue Oct  4 20:53:54 2016
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 79006AF5384;
 Tue,  4 Oct 2016 20:53:54 +0000 (UTC)
 (envelope-from glebius@FreeBSD.org)
Received: from cell.glebi.us (glebi.us [96.95.210.25])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "cell.glebi.us", Issuer "cell.glebi.us" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id 6242EC89;
 Tue,  4 Oct 2016 20:53:53 +0000 (UTC)
 (envelope-from glebius@FreeBSD.org)
Received: from cell.glebi.us (localhost [127.0.0.1])
 by cell.glebi.us (8.15.2/8.15.2) with ESMTPS id u94KrqsU015669
 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Tue, 4 Oct 2016 13:53:52 -0700 (PDT)
 (envelope-from glebius@FreeBSD.org)
Received: (from glebius@localhost)
 by cell.glebi.us (8.15.2/8.15.2/Submit) id u94Krqio015668;
 Tue, 4 Oct 2016 13:53:52 -0700 (PDT)
 (envelope-from glebius@FreeBSD.org)
X-Authentication-Warning: cell.glebi.us: glebius set sender to
 glebius@FreeBSD.org using -f
Date: Tue, 4 Oct 2016 13:53:52 -0700
From: Gleb Smirnoff <glebius@FreeBSD.org>
To: Hiren Panchasara <hiren@FreeBSD.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r306337 - head/sys/kern
Message-ID: <20161004205352.GM23123@FreeBSD.org>
References: <201609261013.u8QADwrV002892@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201609261013.u8QADwrV002892@repo.freebsd.org>
User-Agent: Mutt/1.6.1 (2016-04-27)
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Oct 2016 20:53:54 -0000

  Hiren,

On Mon, Sep 26, 2016 at 10:13:58AM +0000, Hiren Panchasara wrote:
H> Author: hiren
H> Date: Mon Sep 26 10:13:58 2016
H> New Revision: 306337
H> URL: https://svnweb.freebsd.org/changeset/base/306337
H> 
H> Log:
H>   In sendit(), if mp->msg_control is present, then in sockargs() we are allocating
H>   mbuf to store mp->msg_control. Later in kern_sendit(), call to getsock_cap(),
H>   will check validity of file pointer passed, if this fails EBADF is returned but
H>   mbuf allocated in sockargs() is not freed. Fix this possible leak.
H>   
H>   Submitted by:	Lohith Bellad <lohith.bellad@me.com>
H>   Reviewed by:	adrian
H>   MFC after:	3 weeks
H>   Differential Revision:	https://reviews.freebsd.org/D7910

The commit appeared to be incorrect, but a problem exists. I'd like to look at it.
Is there any reproduce recipe for the leak or bug filed?

-- 
Totus tuus, Glebius.