From owner-cvs-src@FreeBSD.ORG Wed Apr 2 14:02:26 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E74F737B405 for ; Wed, 2 Apr 2003 14:02:25 -0800 (PST) Received: from relay.pair.com (relay.pair.com [209.68.1.20]) by mx1.FreeBSD.org (Postfix) with SMTP id ED6C643FCB for ; Wed, 2 Apr 2003 14:02:23 -0800 (PST) (envelope-from silby@silby.com) Received: (qmail 55524 invoked from network); 2 Apr 2003 22:02:23 -0000 Received: from niwun.pair.com (HELO localhost) (209.68.2.70) by relay.pair.com with SMTP; 2 Apr 2003 22:02:23 -0000 X-pair-Authenticated: 209.68.2.70 Date: Wed, 2 Apr 2003 15:58:53 -0600 (CST) From: Mike Silbersack To: Peter Jeremy In-Reply-To: <20030402200546.GA31752@cirb503493.alcatel.com.au> Message-ID: <20030402155327.R662@odysseus.silby.com> References: <200304010821.h318Li4Q091687@repoman.freebsd.org> <200304021447.h32ElHYH008677@dungeon.home> <20030402200546.GA31752@cirb503493.alcatel.com.au> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org cc: Stephen McKay Subject: Re: cvs commit: src/sbin/ping ping.8 ping.c src/share/man/man4 inet.4 ip.4 src/sys/netinet in.h in_pcb.h ip.h ip_input.c ip_output.c ip_var.h src/usr.bin/netstat inet.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Apr 2003 22:02:26 -0000 On Thu, 3 Apr 2003, Peter Jeremy wrote: > >Can we have this invisibly un-commited? > > If you mean "make it so it never happened" then I don't believe this > is possible. To explain, the change means that ping.c (for example) > has gone from rev 1.91 to rev 1.92 - and this change has been fairly > widely disseminated: Lots of people will have CVSup'd it and it's > in the CTM history. If it "never happened" then ping.c will revert > to rev 1.91 (etc). Firstly, I believe CVS doesn't cope well with > this sort of thing. Secondly, the next person to commit to ping.c > will create rev 1.92 - meaning that there are two different rev 1.92 > versions in existence. Hasn't this been done to fix up botched commits in other parts of the tree? > IMHO, this joke isn't so off-colour that it has to disappear from the > repository. I agree that this joke has probably outlived its purpose > but a normal backout should be sufficient for this. > > Peter It's an eyesore in the cvs logs, and it's going to be a point of annoyance for anyone who is looking back through them in the future. Right now you have to scroll down two pages before you see the last real change to ip_output.c in cvsweb. But, if such a rollback would break too many things, I can live with it, assuming that such pranks *never happen again*. Mike "Silby" Silbersack