From nobody Tue Jun 10 18:35:48 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bGyCr3GLdz5y5F7; Tue, 10 Jun 2025 18:35:52 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bGyCr2Q2rz3cgp; Tue, 10 Jun 2025 18:35:52 +0000 (UTC) (envelope-from kp@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1749580552; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fjm+Ju5X9GyV4p3MEzPbuyEqRSc4WKPgIj7KAH444cY=; b=U1xyW2RGJMH1ZUiZ7tL7yjNvdQihLWrhrBDnVLCLpuQQ3oQOi4UlK75P4UNOKUBykv/wIS 34EwU6B4smOi5Yq6PH9md7zCLx60r7KosQvELnHCpFrC0Rs7wEJtIaAMnEvFcLqLpmr8VX iCs19/5qbz8wYEYfYKRBlyXjv8wljqSMvnODk32jj6EZgvEaOnDJE2R7fyH0Jsf9rFN34+ ncgtGQfvsvKxs4IKnjB8i3iQnacY0bXt1rh+Y+KsfjLpuc3ekTIc1scO8NAMrpPspD/Ips hNUgSjiEGEuxuEDSoSbjZnfA2Cbl0OZsjRaN3F3649qFezLraUJUO2CBGVfrMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1749580552; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fjm+Ju5X9GyV4p3MEzPbuyEqRSc4WKPgIj7KAH444cY=; b=hHLhPAbVv/VQtQ6P+qPjASa9QTc/KdYhK6jLXWyTQoyOrl1lATPik7n5sh6JsKzWe90UI0 QyImDJFATFVZmfkTFUtediVGoX8J6FHpc1IrMIZxQjjvKTthy8quxYm3B2pvPI1IKCik5s vJqaLokzjceQ0PPqifh4Df2sWuQ8LwdDjBKCjbOK605LCfkONrPf8ofJFw9/BZDES7cHgn UxzcRdPLrUtLKZJqP0sROLCAznZGWBXOJRgdlATAuNrq7Jd6dfFr4Uf6cuzyAem0rkVZ3u UvJeEMQwRZ4oBJKixpFsJFmCWiw1Jon/H9M4vPt4/eqGMWFZxIVlxBT27zbshw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1749580552; a=rsa-sha256; cv=none; b=rdFzgLeBpHfkjUccCWAgdGuTdxWXzWS84FbBk0n4Tt3QmO5SsGZySG/oUgroUCNpyHBcZ7 LxZoMpqpeLjsColGNFU5WKdEzHt54HxjRrzqrLmDN3ynlRUZax3F+xAV10ksAZTXFyh0RK aK4/EpzIDOOnV4F/HDNeq2IILgQs4S065CYFKTnM+4mt2Wg+aElVRJMOkWM7AnK3V0d8po bZSwWH42V9c9FBo44OzkqKSQCO/7NBpcq/meD34KTuw3DNAr6wtADa6zeNFR5ca0Cngf5d DoqrEWypGEPg+gDnyjiiNP4hQdeXjKOqgl1/mpy9jnSz+3tJVy3w8aJYfPRp4Q== Received: from venus.codepro.be (venus.codepro.be [5.9.86.228]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mx1.codepro.be", Issuer "R10" (verified OK)) (Authenticated sender: kp) by smtp.freebsd.org (Postfix) with ESMTPSA id 4bGyCr14gbzLwZ; Tue, 10 Jun 2025 18:35:52 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: by venus.codepro.be (Postfix, authenticated sender kp) id B1F599DA5; Tue, 10 Jun 2025 20:35:49 +0200 (CEST) From: Kristof Provost To: Gleb Smirnoff Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 948078b65c27 - main - pf: fix !VIMAGE build Date: Tue, 10 Jun 2025 14:35:48 -0400 X-Mailer: MailMate (2.0r6255) Message-ID: <6347B11C-FEEE-41C3-8A88-B79BE06C1CE0@FreeBSD.org> In-Reply-To: <202506100319.55A3JJr1086016@gitrepo.freebsd.org> References: <202506100319.55A3JJr1086016@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="=_MailMate_ADE4FA85-C5E6-4EC9-8EAC-47829DBF6563_=" --=_MailMate_ADE4FA85-C5E6-4EC9-8EAC-47829DBF6563_= Content-Type: text/plain; charset=UTF-8; format=flowed; markup=markdown Content-Transfer-Encoding: quoted-printable On 9 Jun 2025, at 23:19, Gleb Smirnoff wrote: > The branch main has been updated by glebius: > > URL: = > https://cgit.FreeBSD.org/src/commit/?id=3D948078b65c275acfa55afe56a9bbd= eb2f61f1e2a > > commit 948078b65c275acfa55afe56a9bbdeb2f61f1e2a > Author: Gleb Smirnoff > AuthorDate: 2025-06-10 03:19:04 +0000 > Commit: Gleb Smirnoff > CommitDate: 2025-06-10 03:19:04 +0000 > > pf: fix !VIMAGE build Thanks for the fix. I was sure I=E2=80=99d done a make universe, but given the NOINET6 breaka= ge I = must be misremembering. Still, that wouldn=E2=80=99t have caught this one. It looks like we don=E2= =80=99t = have a single kernel config without VIMAGE left, and that makes it a bit = harder to detect this sort of breakage. I know that at least Netflix do care about that configuration, so I = think we should have a LINT-NOVIMAGE to make it at least a bit more = likely that we=E2=80=99ll detect such breakage before commits: = https://reviews.freebsd.org/D50780 =E2=80=94 Kristof --=_MailMate_ADE4FA85-C5E6-4EC9-8EAC-47829DBF6563_= Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

On 9 Jun 2025, at 23:19, Gleb Smirnoff wrote:

The branch main has been updated by glebius:

URL: https://cgit.FreeBSD.org/src/co= mmit/?id=3D948078b65c275acfa55afe56a9bbdeb2f61f1e2a

commit 948078b65c275acfa55afe56a9bbdeb2f61f1e2a
Author: Gleb Smirnoff glebius@= FreeBSD.org
AuthorDate: 2025-06-10 03:19:04 +0000
Commit: Gleb Smirnoff glebius@= FreeBSD.org
CommitDate: 2025-06-10 03:19:04 +0000

pf=
: fix !VIMAGE build

Thanks for the fix.
I was sure I=E2=80=99d done a make universe, but given the NOINET6 breaka= ge I must be misremembering.

Still, that wouldn=E2=80=99t have caught this one. It loo= ks like we don=E2=80=99t have a single kernel config without VIMAGE left,= and that makes it a bit harder to detect this sort of breakage.
I know that at least Netflix do care about that configuration, so I think= we should have a LINT-NOVIMAGE to make it at least a bit more likely tha= t we=E2=80=99ll detect such breakage before commits: https://reviews.freebsd.org/D50780

=E2=80=94
Kristof

--=_MailMate_ADE4FA85-C5E6-4EC9-8EAC-47829DBF6563_=--