From owner-freebsd-xen@FreeBSD.ORG  Tue Jan  7 21:33:22 2014
Return-Path: <owner-freebsd-xen@FreeBSD.ORG>
Delivered-To: freebsd-xen@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id B8F5A970
 for <freebsd-xen@freebsd.org>; Tue,  7 Jan 2014 21:33:22 +0000 (UTC)
Received: from mail-ea0-f170.google.com (mail-ea0-f170.google.com
 [209.85.215.170])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 4A0B910E6
 for <freebsd-xen@freebsd.org>; Tue,  7 Jan 2014 21:33:22 +0000 (UTC)
Received: by mail-ea0-f170.google.com with SMTP id k10so461698eaj.29
 for <freebsd-xen@freebsd.org>; Tue, 07 Jan 2014 13:33:15 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to
 :cc:subject:references:in-reply-to:content-type
 :content-transfer-encoding;
 bh=0SxlaLUou9Ffhh1tUeK/tDf4/FBO2J7S66YOw1gDYJ8=;
 b=VT4NakzKda+av9+mQacoebfA3WwjzyNLhh7eLV4689MUGBwvk0VsGJbv/MtgDIscgy
 6g+49BDAzgpTWpMEoo40nyPT2PBqgiO5l2cJK+vUSLvisnBVUi4MZq+vTZdJV2sHRMlM
 ObefTywNFiZAIvxb+RZ+1GEUknulL9Qjnt3vH6oT7XnjRKv0v/klVQM0LHOzZavKCOXw
 SnLr2kDuUKNYnbY7MehzjfEx0dFNUxC6lOOSoVqJ26/8+kkAaWb9qyXDlzUeGNZhRpTj
 KBAY/x+xc7uKJe/qZ/leaMIbK0AINvCbGPG2hQmVj0fVo8XRwme9Z5TZyywyYEhhKwmD
 3W6Q==
X-Gm-Message-State: ALoCoQnfFQ+3UC9elsInv6isDBX1M7Wd5FE08LSmyQcKgt4yYDv11sUlrg3zSbckij9c7meyjaxO
X-Received: by 10.14.200.197 with SMTP id z45mr10150331een.98.1389129976815;
 Tue, 07 Jan 2014 13:26:16 -0800 (PST)
Received: from [10.80.2.139] ([185.25.64.249])
 by mx.google.com with ESMTPSA id a45sm183519622eem.6.2014.01.07.13.26.15
 for <multiple recipients>
 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);
 Tue, 07 Jan 2014 13:26:15 -0800 (PST)
Message-ID: <52CC70F6.5060502@linaro.org>
Date: Tue, 07 Jan 2014 21:26:14 +0000
From: Julien Grall <julien.grall@linaro.org>
User-Agent: Mozilla/5.0 (X11; Linux i686;
 rv:17.0) Gecko/20131104 Icedove/17.0.10
MIME-Version: 1.0
To: Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [Xen-devel] [PATCH v9 03/19] xen: add and enable Xen console
 for PVH guests
References: <1388677433-49525-1-git-send-email-roger.pau@citrix.com>
 <1388677433-49525-4-git-send-email-roger.pau@citrix.com>
In-Reply-To: <1388677433-49525-4-git-send-email-roger.pau@citrix.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: jhb@freebsd.org, xen-devel@lists.xen.org, julien.grall@citrix.com,
 freebsd-xen@freebsd.org, freebsd-current@freebsd.org, kib@freebsd.org,
 gibbs@freebsd.org
X-BeenThere: freebsd-xen@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Discussion of the freebsd port to xen - implementation and usage
 <freebsd-xen.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-xen>,
 <mailto:freebsd-xen-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-xen/>
List-Post: <mailto:freebsd-xen@freebsd.org>
List-Help: <mailto:freebsd-xen-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-xen>,
 <mailto:freebsd-xen-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 07 Jan 2014 21:33:22 -0000

On 01/02/2014 03:43 PM, Roger Pau Monne wrote:
> This adds and enables the console used on XEN kernels.
> ---

[..]

> +/* Debug function, prints directly to hypervisor console */
> +void xc_printf(const char *, ...);
> +

Can you add __printflike(...)? It will be easier to catch bad format.

-- 
Julien Grall