From owner-svn-src-head@freebsd.org Tue Jan 10 07:58:58 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 00374CA9509; Tue, 10 Jan 2017 07:58:58 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf0-x231.google.com (mail-pf0-x231.google.com [IPv6:2607:f8b0:400e:c00::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C1F531E2A; Tue, 10 Jan 2017 07:58:57 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pf0-x231.google.com with SMTP id y143so22391855pfb.0; Mon, 09 Jan 2017 23:58:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=/BJqKDsd9x9nKubbGuyrHeQlKQVzFGgnxPpExF4ohzU=; b=CpF8EOBEjf+a1nzIfQwTV15OD9FnvEq5Ol9OGdc1RkKdG4+1UbMrDFb0KzlRdQRuim h4O+iadfTf0u1hVrLt52tHMFzS9gZfWvGVCj3Tbfrm6gHpnsIIX672Vrna1Ilrw5fHnE zMxX0GZ9ODlbt9lINrGRX0SF0AgkwCjnCtt2mxHG24OM4A2sQ+s1gWrCDsPEqSsAnr4w neJCNQJV1VGrGAq7lvluVbwbBg1S6QaDZVrtW6VI/Xm2kDMEA4SyLusgogx86gOpN+cX h9keqE+najs7ai5CLcqaMZqFVYv47NaJ1N78N3YOn5im2recCZgSiXGKPan+/fF0tymu GGUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=/BJqKDsd9x9nKubbGuyrHeQlKQVzFGgnxPpExF4ohzU=; b=EfXYsWPxRF68tYFvzowliJgXY5YityVAPmFNozrcuw1vgsFzY+r7uxHKf4F/goJZat 5vAkcly6l2ENzdaW11S1pJawNRtIpvh9tO1+xGBOJIqfG1Mu3EAsOkQhWiyMVg0yxQog tSMn7daxR7eCdjYyGw3S300L1XCoFxnH6LOCke2Qa6620NVDiJRUyJiPRl+Rv0tDsTsG 22yxuE3PMkALP0SnXrxdMM+94JmNqjbzjLKyNMGON+Yd6uRblNiBEjNeMBavT+L5SW8T uViCzFNerWn+IXv7QhaNE4ZWOc4TssfgX+kzXvNNVhCgg7UmrkM7BYavB426GlfYb8cJ KweQ== X-Gm-Message-State: AIkVDXJUeuTvf2UJGvr4FdhzXHepWjaICdbTWP/ADA/O1VqE2ZkK7tlHxfgaZXx9QeTCUQ== X-Received: by 10.84.204.8 with SMTP id a8mr3101161ple.172.1484035137388; Mon, 09 Jan 2017 23:58:57 -0800 (PST) Received: from fuji-wireless.local (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id n84sm2971684pfk.25.2017.01.09.23.58.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 09 Jan 2017 23:58:56 -0800 (PST) From: "Ngie Cooper (yaneurabeya)" Message-Id: <18D51B59-6985-49FA-83E6-225B560053B5@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 10.2 \(3259\)) Subject: Re: svn commit: r311585 - in head: crypto/openssh secure/usr.sbin/sshd Date: Mon, 9 Jan 2017 23:58:55 -0800 In-Reply-To: Cc: Ngie Cooper , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org, d@delphij.net, des@freebsd.org To: Xin Li References: <201701070808.v0788aEi064973@repo.freebsd.org> X-Mailer: Apple Mail (2.3259) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Jan 2017 07:58:58 -0000 > On Jan 9, 2017, at 11:56 PM, Xin Li wrote: >=20 >=20 > On 1/7/17 00:08, Ngie Cooper wrote: >> Author: ngie >> Date: Sat Jan 7 08:08:35 2017 >> New Revision: 311585 >> URL: https://svnweb.freebsd.org/changeset/base/311585 >>=20 >> Log: >> Conditionalize building libwrap support into sshd >>=20 >> Only build libwrap support into sshd if MK_TCP_WRAPPERS !=3D no >>=20 >> This will unbreak the build if libwrap has been removed from the = system >>=20 >> MFC after: 2 weeks >> PR: 210141 >> Submitted by: kpect@protonmail.com >> Differential Revision: D9049 >=20 > I didn't see this approved by maintainer, did you ping him? >=20 > [delphij@saturn] /usr/src> grep ssh MAINTAINERS > openssh des Pre-commit review requested. >=20 > (Not that the change itself is bad, though, but it's important to keep > everyone on the same page). I waited 3 days for a reply on the review: = https://reviews.freebsd.org/D9049 . = Admittedly, it was a bit short of a timeout. -Ngie=