From owner-cvs-src@FreeBSD.ORG  Thu May  3 05:16:38 2007
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@freebsd.org
Delivered-To: cvs-src@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 486F616A401;
	Thu,  3 May 2007 05:16:38 +0000 (UTC)
	(envelope-from kientzle@freebsd.org)
Received: from kientzle.com (h-66-166-149-50.snvacaid.covad.net
	[66.166.149.50])
	by mx1.freebsd.org (Postfix) with ESMTP id 256A513C459;
	Thu,  3 May 2007 05:16:38 +0000 (UTC)
	(envelope-from kientzle@freebsd.org)
Received: from [10.0.0.222] (p54.kientzle.com [66.166.149.54])
	by kientzle.com (8.12.9/8.12.9) with ESMTP id l435GbH7044558;
	Wed, 2 May 2007 22:16:37 -0700 (PDT)
	(envelope-from kientzle@freebsd.org)
Message-ID: <46397035.7000606@freebsd.org>
Date: Wed, 02 May 2007 22:16:37 -0700
From: Tim Kientzle <kientzle@freebsd.org>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.12) Gecko/20060422
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Colin Percival <cperciva@freebsd.org>
References: <200705030433.l434XBvW005733@repoman.freebsd.org>
In-Reply-To: <200705030433.l434XBvW005733@repoman.freebsd.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org
Subject: Re: cvs commit: src/usr.bin/tar write.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 03 May 2007 05:16:38 -0000

Colin Percival wrote:
> cperciva    2007-05-03 04:33:11 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     usr.bin/tar          write.c 
>   Log:
>   If lstat(2) fails, have bsdtar return a non-zero exit code if the
>   failed path is one which was specified on the command line.

This looks like a nice compromise.

I wonder if it would be simpler to set non-zero exit only
if this is the first path returned from tree_next() (which
should be the path given on the command line).  That
would avoid the headache of having to perform a textual
path comparison.

A simple flag to indicate if this is the first time
through the loop should suffice, I think.

Tim