From owner-dev-commits-src-all@freebsd.org Tue Dec 29 23:32:53 2020 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2C8714CE4B7; Tue, 29 Dec 2020 23:32:53 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4D59h50WJvz3nlY; Tue, 29 Dec 2020 23:32:53 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-qt1-f181.google.com (mail-qt1-f181.google.com [209.85.160.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id 043E32DDF7; Tue, 29 Dec 2020 23:32:53 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-qt1-f181.google.com with SMTP id v5so9994659qtv.7; Tue, 29 Dec 2020 15:32:53 -0800 (PST) X-Gm-Message-State: AOAM531Da3rull9z259xldBHH9uwj+YDdZPH7hkdf1B0RIMOhHeci7wN 8/NKVulZWegRbbDS5fCWojmu1KNzxlyR3Cmu5DY= X-Google-Smtp-Source: ABdhPJx43GpNZv3ehczfD9EyEaFNDlzUimF6k4Ck95EGHucYESFzS6DvrcE7nL07F25SilD2txSFBW1VJEh8+TaIAQY= X-Received: by 2002:ac8:7141:: with SMTP id h1mr50340234qtp.211.1609284772412; Tue, 29 Dec 2020 15:32:52 -0800 (PST) MIME-Version: 1.0 References: <202012292306.0BTN6ivw093358@gitrepo.freebsd.org> In-Reply-To: <202012292306.0BTN6ivw093358@gitrepo.freebsd.org> From: Kyle Evans Date: Tue, 29 Dec 2020 17:32:40 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 269b7d8ac1e5 - stable/12 - tftpd: tests: raise targeted cstd to c11 To: Ryan Libby Cc: src-committers , dev-commits-src-all@freebsd.org, dev-commits-src-branches@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: "Commit messages for all branches of the src repository." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Dec 2020 23:32:53 -0000 Hmm, I hadn't done this because we still have in-tree GCC4.2. Might want to go ahead and skip these tests entirely a level up for 4.2. On Tue, Dec 29, 2020, 17:07 Ryan Libby wrote: > The branch stable/12 has been updated by rlibby: > > URL: > https://cgit.FreeBSD.org/src/commit/?id=269b7d8ac1e533a1f214904ab7bce50f5c14fe3e > > commit 269b7d8ac1e533a1f214904ab7bce50f5c14fe3e > Author: Kyle Evans > AuthorDate: 2020-03-05 22:45:16 +0000 > Commit: Ryan Libby > CommitDate: 2020-12-29 23:04:40 +0000 > > tftpd: tests: raise targeted cstd to c11 > > r358556 added alignas() use to the functional tests, which isn't > defined > until C11. Raise the -std to C11 to fix the build under > freebsd-gcc{6,9}. > > Reported by: mhorne, Jenkins/CI > > (cherry picked from commit 924e10b809a9fcbc8688c1b5848f60b48e6103fe) > --- > libexec/tftpd/tests/Makefile | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libexec/tftpd/tests/Makefile b/libexec/tftpd/tests/Makefile > index 06c5537372a7..9aa420cec1a5 100644 > --- a/libexec/tftpd/tests/Makefile > +++ b/libexec/tftpd/tests/Makefile > @@ -10,5 +10,6 @@ TEST_METADATA.functional+= timeout=15 > > LIBADD= util > WARNS?= 6 > +CSTD= c11 > > .include >