Date: Tue, 11 Feb 2003 11:23:30 +0100 (CET) From: Harti Brandt <brandt@fokus.fraunhofer.de> To: atm@freebsd.org Subject: Bug in hea driver? Message-ID: <20030211112002.S3497@beagle.fokus.gmd.de>
next in thread | raw e-mail | index | archive | help
This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. Send mail to mime@docserver.cac.washington.edu for more info. --0-756721336-1044959010=:3497 Content-Type: TEXT/PLAIN; charset=US-ASCII Hi all, could someone please comment on the attached patch? There seems to be a bug in the on-card memory allocator. The problem is, that when we need to split a block that appears to be large enough because of alignment, we want to check, that what remains after splitting is large enough (with regard to the size we are trying to allocated), not that it is >= 0. The test for >= 0 should always be true, because a block of size N (N beeing a power of two) always contains an address that is aligned to N, so that the upper half when splitting such a block is always >= 0. harti -- harti brandt, http://www.fokus.gmd.de/research/cc/cats/employees/hartmut.brandt/private brandt@fokus.fraunhofer.de, harti@freebsd.org --0-756721336-1044959010=:3497 Content-Type: TEXT/PLAIN; charset=US-ASCII; name="hea.p0" Content-Transfer-Encoding: BASE64 Content-ID: <20030211112330.P3497@beagle.fokus.gmd.de> Content-Description: Content-Disposition: attachment; filename="hea.p0" SW5kZXg6IGVuaV9idWZmZXIuYw0KPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0K UkNTIGZpbGU6IC9ob21lL25jdnMvc3JjL3N5cy9kZXYvaGVhL2VuaV9idWZm ZXIuYyx2DQpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMTUNCmRpZmYgLXUgLXIx LjE1IGVuaV9idWZmZXIuYw0KLS0tIGVuaV9idWZmZXIuYwk4IE5vdiAyMDAy IDE4OjI3OjI4IC0wMDAwCTEuMTUNCisrKyBlbmlfYnVmZmVyLmMJMTEgRmVi IDIwMDMgMTA6MTk6NTggLTAwMDANCkBAIC0yNjcsNyArMjY3LDcgQEANCiAJ CSAgICAvKg0KIAkJICAgICAqIElmIHdlIHVzZSB0aGlzIGFsaWdubWVudCwg d2lsbCBpdCBzdGlsbCBmaXQ/DQogCQkgICAgICovDQotCQkgICAgaWYgKCAo ZXB0ci0+c2l6ZSAtIChuYmFzZSAtIGVwdHItPmJhc2UpKSA+PSAwICkNCisJ CSAgICBpZiAoIChlcHRyLT5zaXplIC0gKG5iYXNlIC0gZXB0ci0+YmFzZSkp ID49IG5zaXplICkNCiAJCSAgICB7DQogCQkJTWJkCSpldG1wOw0KIA0K --0-756721336-1044959010=:3497-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-atm" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030211112002.S3497>