From owner-cvs-all Thu Apr 13 11:18:56 2000 Delivered-To: cvs-all@freebsd.org Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by hub.freebsd.org (Postfix) with ESMTP id E08E937B5D2; Thu, 13 Apr 2000 11:18:46 -0700 (PDT) (envelope-from bde@zeta.org.au) Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102]) by mailman.zeta.org.au (8.8.7/8.8.7) with ESMTP id EAA19362; Fri, 14 Apr 2000 04:18:26 +1000 Date: Fri, 14 Apr 2000 04:18:25 +1000 (EST) From: Bruce Evans X-Sender: bde@alphplex.bde.org To: Warner Losh Cc: Bill Fumerola , Ustimenko Semen , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/pci if_tx.c if_txvar.h In-Reply-To: <200004122036.OAA39907@harmony.village.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > In message <20000412132155.J23367@jade.chc-chimes.com> Bill Fumerola writes: > : On Tue, Apr 11, 2000 at 11:51:45PM -0700, Ustimenko Semen wrote: > : > semenu 2000/04/11 23:51:45 PDT > : > > : > Modified files: > : > sys/pci if_tx.c if_txvar.h > : > Log: > : > Driver is now using miibus, and newbus. > : > > : > PR: kern/17601 > : > : This breaks world (sys/modules/tx). > It appears to need a shim define (it should likely be converted to > newbus completely) as well as bpf.h. I think the latter can be > removed completely. It still has "#if NBPF > 0", so removing the include of "bpf.h" would break bpf support in all cases, not just for modules. Most drivers have been converted to support bpf unconditionally. All the modularized ones certainly had been converted. Several drivers use the even more bogus "#if NBPFILTER > 0", but its not clear that this breaks anything because it seems to be mostly inside ifdef tangles. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message