From owner-dev-commits-src-main@freebsd.org  Wed Aug 18 17:39:50 2021
Return-Path: <owner-dev-commits-src-main@freebsd.org>
Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id A79B865347E;
 Wed, 18 Aug 2021 17:39:50 +0000 (UTC) (envelope-from jhb@FreeBSD.org)
Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 4GqZsf48RXz4pm9;
 Wed, 18 Aug 2021 17:39:50 +0000 (UTC) (envelope-from jhb@FreeBSD.org)
Received: from John-Baldwins-MacBook-Pro.local (ralph.baldwin.cx
 [66.234.199.215])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client did not present a certificate) (Authenticated sender: jhb)
 by smtp.freebsd.org (Postfix) with ESMTPSA id E56652C544;
 Wed, 18 Aug 2021 17:39:49 +0000 (UTC) (envelope-from jhb@FreeBSD.org)
Subject: Re: git: a051ca72e281 - main - Introduce m_get3()
To: Kristof Provost <kp@FreeBSD.org>, src-committers@FreeBSD.org,
 dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
References: <202108180852.17I8q2Wl009885@gitrepo.freebsd.org>
Cc: Navdeep Parhar <np@freebsd.org>
From: John Baldwin <jhb@FreeBSD.org>
Message-ID: <e3eee4c4-058e-416c-80fe-c5203d072303@FreeBSD.org>
Date: Wed, 18 Aug 2021 10:39:45 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:78.0)
 Gecko/20100101 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <202108180852.17I8q2Wl009885@gitrepo.freebsd.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-BeenThere: dev-commits-src-main@freebsd.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: Commit messages for the main branch of the src repository
 <dev-commits-src-main.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/dev-commits-src-main>, 
 <mailto:dev-commits-src-main-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/dev-commits-src-main/>
List-Post: <mailto:dev-commits-src-main@freebsd.org>
List-Help: <mailto:dev-commits-src-main-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/dev-commits-src-main>, 
 <mailto:dev-commits-src-main-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 18 Aug 2021 17:39:50 -0000

On 8/18/21 1:52 AM, Kristof Provost wrote:
> The branch main has been updated by kp:
> 
> URL: https://cgit.FreeBSD.org/src/commit/?id=a051ca72e2815b9bbba1e422f5abf22bc2a01551
> 
> commit a051ca72e2815b9bbba1e422f5abf22bc2a01551
> Author:     Kristof Provost <kp@FreeBSD.org>
> AuthorDate: 2021-08-07 18:02:21 +0000
> Commit:     Kristof Provost <kp@FreeBSD.org>
> CommitDate: 2021-08-18 06:48:27 +0000
> 
>      Introduce m_get3()
>      
>      Introduce m_get3() which is similar to m_get2(), but can allocate up to
>      MJUM16BYTES bytes (m_get2() can only allocate up to MJUMPAGESIZE).
>      
>      This simplifies the bpf improvement in f13da24715.
>      
>      Suggested by:   glebius
>      Differential Revision:  https://reviews.freebsd.org/D31455

Hmm, if this looped the way m_getm2() does I could use this in
icl_cxgbei_conn_pdu_append_data() in sys/dev/cxgbe/cxgbei/icl_cxgbei.c
where the code currently allocates 16k jumbo's by hand and then uses
m_getm2() for the trailer.

One almost wants a variant of m_getm*() where you can give an explicit
"max cluster size" perhaps instead of having to know the magic
implicit sizes for m_getm2 vs m_getm3.

-- 
John Baldwin