From owner-svn-src-head@freebsd.org  Thu Oct  1 15:46:49 2020
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id 984DD42BC5A;
 Thu,  1 Oct 2020 15:46:49 +0000 (UTC)
 (envelope-from kevans@freebsd.org)
Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "smtp.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 4C2HYP3Wk3z4JC1;
 Thu,  1 Oct 2020 15:46:49 +0000 (UTC)
 (envelope-from kevans@freebsd.org)
Received: from mail-qt1-f171.google.com (mail-qt1-f171.google.com
 [209.85.160.171])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK))
 (Authenticated sender: kevans)
 by smtp.freebsd.org (Postfix) with ESMTPSA id 5602E16132;
 Thu,  1 Oct 2020 15:46:49 +0000 (UTC)
 (envelope-from kevans@freebsd.org)
Received: by mail-qt1-f171.google.com with SMTP id y11so4806962qtn.9;
 Thu, 01 Oct 2020 08:46:49 -0700 (PDT)
X-Gm-Message-State: AOAM531Oh3d2+f5tgzy/88YXPJho83vRLcsjy8maLPQRnKuLVtv4P4eA
 RnWpjvLDzGJqDeydfMpWTrL/fDxaXSDNlirTzgM=
X-Google-Smtp-Source: ABdhPJyLYGTc6kUDeGUzDNwdtqk/vXBY9lUqw47Y6WQKdbCnyWClbUY3qcTzLNV5hh/znBi+l7fbeHI158DDf78a+bk=
X-Received: by 2002:ac8:3261:: with SMTP id y30mr8367484qta.242.1601567208897; 
 Thu, 01 Oct 2020 08:46:48 -0700 (PDT)
MIME-Version: 1.0
References: <202009272226.08RMQf1h054050@repo.freebsd.org>
 <20200927231519.GI2643@kib.kiev.ua>
 <CAOtMX2iUKpFrJC1vUJ5_AF75L_GDr_4Rui2TdrA-qPLRc8aDNw@mail.gmail.com>
 <20200928150405.GO2643@kib.kiev.ua>
 <CACNAnaHWmZuusQeYMFiDG1wBxtJK6c8qa0Nv8im2M9SExP2gRA@mail.gmail.com>
 <20200928160138.GP2643@kib.kiev.ua> <20201001154445.GA2643@kib.kiev.ua>
In-Reply-To: <20201001154445.GA2643@kib.kiev.ua>
From: Kyle Evans <kevans@freebsd.org>
Date: Thu, 1 Oct 2020 10:46:36 -0500
X-Gmail-Original-Message-ID: <CACNAnaH4va_h+sJXjU=0sm6VerAVONunemCY61QFZPiuMtEdRA@mail.gmail.com>
Message-ID: <CACNAnaH4va_h+sJXjU=0sm6VerAVONunemCY61QFZPiuMtEdRA@mail.gmail.com>
Subject: Re: svn commit: r366207 - head/lib/libc/gen
To: Konstantin Belousov <kostikbel@gmail.com>
Cc: Kyle Evans <kevans@freebsd.org>, Alan Somers <asomers@freebsd.org>, 
 src-committers <src-committers@freebsd.org>,
 svn-src-all <svn-src-all@freebsd.org>, 
 svn-src-head <svn-src-head@freebsd.org>
Content-Type: text/plain; charset="UTF-8"
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.33
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 01 Oct 2020 15:46:49 -0000

On Thu, Oct 1, 2020 at 10:45 AM Konstantin Belousov <kostikbel@gmail.com> wrote:
>
> On Mon, Sep 28, 2020 at 07:01:38PM +0300, Konstantin Belousov wrote:
> > On Mon, Sep 28, 2020 at 10:06:55AM -0500, Kyle Evans wrote:
> > > I would be tempted to just revert the rest of the local modifications
> > > (sans negative check, maybe) and widen it in the one spot that the
> > > compiler complains about:
> > >
> > > -                     if (strlcpy(buf, execpath, buflen_) >= buflen_)
> > > +                     if (strlcpy(buf, execpath, buflen) >= (size_t)buflen)
> > >
> > > I had expressed this in the review, but with no particular conviction.
> > If this is the only place where the warning occurs, IMO it would be quite
> > good to reduce the change.
>
> So would you propose your change for review ?

Sure, I'll throw it up here in a little bit.