From nobody Mon Dec 29 21:21:34 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dg8Kq6pN1z6MMWC; Mon, 29 Dec 2025 21:21:35 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dg8Kq5zrPz3rdW; Mon, 29 Dec 2025 21:21:35 +0000 (UTC) (envelope-from dim@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1767043295; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EEWMJl75m8269Xs371tNmH8aHhLOdm8PexcpV1b+xy8=; b=xISDyhn4vQlV3c1/2xOpQINXx4z+D6P/rv6rzEXJkjF8VuWqwMCLNgVMdrxryGJxmKaoAZ R/Dhj1WyYVLmd9Xenuo1tt6SZ3WJDrI9eD2GjW/Jy549uH6l7Wzd7Qqi/yC+5KhAZJY93D 7DcKN3r0BLuCWUHGRw6itp+0jwQ42sOrbPkdCVWjOB45zKzn4M9w7AyxrJGXDVnTlCiIiu rfTTQwywqhiY0nJhFxNNDkSWwZmhCuzvh3cEtHxMRX4u6iWCna9aOo8gVS+yK6LFcbwGnJ 3Z7sbDpjLC7LTOXZre/QFF/OVrmGX+CPjuAUCEUffnQxBCWzKJXMnWR2IyeOsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1767043295; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EEWMJl75m8269Xs371tNmH8aHhLOdm8PexcpV1b+xy8=; b=m7pD032Qfa+RYyGxlGym0aDlRlkSTv81CaJblobdU2omM4xBFh6U/wpwJMa2ijbocikCuY qv3o5PAGQ+IwUoPlQ1iJa2rzFlA4AiypsiFxjjE9sL5IzvGuQZfw+QPQZ3RTQyT48xscVg AqV5Ee8sghBVVCwauuffCpLYq4Rk/TaJt9n9xVIL3IOpliZuuTnIJnhzrYR3DI0xIQSJMH rUJ3ACP7UtrYeKaVFg/TBZA4tHUfBV2zewN5GE5TXwCveRNhErPwWyciMpvagTH4EJ1JiA sAG3r9cIlOKr2kb+zYsiC8imOiFoiJd4oCtiJFj5riMvy6yupygB1Iblaxio8w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1767043295; a=rsa-sha256; cv=none; b=wM/ZADUGa0+PtBD6SlqIPW2Vu4J8JWdxe33xI58Ra79hYKxxz33z6aeIB44eSzo9I9bJOx LXqt25mY1Yp9F79LkyNk5LtAWlhMruXhPYzQjv1yk3FCxjtikaQltrKgWeD3m596bPk2Mo twSJ6vuRPIUOOUPQW1vBo5pPR8OXEF/c3lj2ENKEB5eHit5G9Nd3xhXR7hE5aPQw38kdFj wrq2p6bUC0XVdZWKapeoVEH/xAJSJxj+95QJ3UwtvtHSXeeloKi1h10sXZpT52CyOncs0Y LBgThX8KXiH6ttbgMq5hdVbTT+5hanM0+QSItS6Xq+siWT0Np3u7zXs94Lxhcg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature ECDSA (prime256v1) client-digest SHA256) (Client CN "tensor.andric.com", Issuer "E7" (verified OK)) (Authenticated sender: dim) by smtp.freebsd.org (Postfix) with ESMTPSA id 4dg8Kq4bbbzn4X; Mon, 29 Dec 2025 21:21:35 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from smtpclient.apple (bladnoch.home.andric.com [192.168.0.20]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id 5E09E5B1D6; Mon, 29 Dec 2025 22:21:34 +0100 (CET) Content-Type: text/plain; charset=us-ascii List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81.1.4\)) Subject: Re: git: 2ade7285253f - stable/14 - tools.build: add sys/cdefs.h to SYSINCS, since lots of other headers use it From: Dimitry Andric In-Reply-To: Date: Mon, 29 Dec 2025 22:21:34 +0100 Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-branches@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <69527170.31d92.5af51114@gitrepo.freebsd.org> To: Mark Johnston X-Mailer: Apple Mail (2.3826.700.81.1.4) On 29 Dec 2025, at 21:58, Mark Johnston wrote: >=20 > On Mon, Dec 29, 2025 at 12:17:52PM +0000, Dimitry Andric wrote: >> The branch stable/14 has been updated by dim: >>=20 >> URL: = https://cgit.FreeBSD.org/src/commit/?id=3D2ade7285253fc5dfe0adfc51f7bd342b= 9293f253 >>=20 >> commit 2ade7285253fc5dfe0adfc51f7bd342b9293f253 >> Author: Dimitry Andric >> AuthorDate: 2025-12-26 15:26:13 +0000 >> Commit: Dimitry Andric >> CommitDate: 2025-12-29 12:16:00 +0000 >>=20 >> tools.build: add sys/cdefs.h to SYSINCS, since lots of other = headers use it >>=20 >> This is needed to let the legacy stage compile against newer = versions of >> sys/font.h, which transitively includes sys/cdefs.h, and requires = the >> new __nonstring macro from it. >>=20 >> Fixes: e2c93ed09f25 >> MFC after: 3 days >>=20 >> (cherry picked from commit = 1c9ff80f06350fa44b7e50ce09ad665ab0082abb) >=20 > Hi Dimitry, >=20 > After this commit, I can't build stable/14 on main (commit = 88b04633c29e > to be exact) anymore. Here's the output from a buildworld, it fails > pretty much immediately: > https://reviews.freebsd.org/P683 >=20 > The same seems to be true on stable/13, but not on stable/15. Hmm, this turns out to be a bit deeper rabbit hole than I anticipated. = The cdefs.h header on stable/14 and stable/13 are quite behind the one = on main and stable/15. This causes issues like the above, when = __noexcept, __deprecated1 and others are not defined during the legacy = stage, and it picks up _some_ headers from the host system, and others = from the location installed by tools/build/Makefile. I think I will rollback the MFCs for now, until I can figure out a = solution. Ideally we would not have to copy cdefs.h for this bootstrap = part, but that leads to other issues. -Dimitry