From owner-cvs-src@FreeBSD.ORG  Thu Mar 27 07:52:42 2008
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id CD2C51065672;
	Thu, 27 Mar 2008 07:52:42 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42])
	by mx1.freebsd.org (Postfix) with ESMTP id A00BD8FC1D;
	Thu, 27 Mar 2008 07:52:42 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from fledge.watson.org (fledge.watson.org [209.31.154.41])
	by cyrus.watson.org (Postfix) with ESMTP id 303C046C37;
	Thu, 27 Mar 2008 03:52:42 -0400 (EDT)
Date: Thu, 27 Mar 2008 07:52:42 +0000 (GMT)
From: Robert Watson <rwatson@FreeBSD.org>
X-X-Sender: robert@fledge.watson.org
To: John Birrell <jb@FreeBSD.org>
In-Reply-To: <200803270503.m2R53Qr7053473@repoman.freebsd.org>
Message-ID: <20080327072329.U34007@fledge.watson.org>
References: <200803270503.m2R53Qr7053473@repoman.freebsd.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/amd64/include param.h src/sys/arm/include 
 param.h src/sys/i386/include param.h src/sys/ia64/include param.h 
 src/sys/powerpc/include param.h src/sys/sparc64/include param.h 
 src/sys/sun4v/include param.h
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 27 Mar 2008 07:52:43 -0000


On Thu, 27 Mar 2008, John Birrell wrote:

> jb          2008-03-27 05:03:26 UTC
>
>  FreeBSD src repository
>
>  Modified files:
>    sys/amd64/include    param.h
>    sys/arm/include      param.h
>    sys/i386/include     param.h
>    sys/ia64/include     param.h
>    sys/powerpc/include  param.h
>    sys/sparc64/include  param.h
>    sys/sun4v/include    param.h
>  Log:
>  When building a kernel module, define MAXCPU the same as SMP so
>  that modules work with and without SMP.

Hmm.  I think this probably is the right thing, but we'll need to be very 
careful to watch for people defining foo[MAXCPU] in globally visible data 
structures in the kernel in such a way that entries for the non-current CPU 
are referenced by any modules.  A casual glance suggests that, right now, this 
is not generally an issue, but something to watch out for, since we do use 
MAXCPU to size a number of kernel data structures.

Robert N M Watson
Computer Laboratory
University of Cambridge