From nobody Wed Oct 11 03:28:26 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4S4ysV5sv0z4wmKL; Wed, 11 Oct 2023 03:28:30 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-yb1-xb2b.google.com (mail-yb1-xb2b.google.com [IPv6:2607:f8b0:4864:20::b2b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4S4ysV2QBWz3G80; Wed, 11 Oct 2023 03:28:30 +0000 (UTC) (envelope-from mavbsd@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-yb1-xb2b.google.com with SMTP id 3f1490d57ef6-d9a518d66a1so1905367276.0; Tue, 10 Oct 2023 20:28:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696994909; x=1697599709; darn=freebsd.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=5kL0i+lvGxYVm5/EfnWo2tpujMq+OvDoFyDLAloC0WE=; b=A/jYNjKUfNxuEr7Ck8EMJnXaLyivjSXGJxrltyDwguHGyAfK0Kxi5R41Gvcl3gOT2l /UR1+wXL6fFQLq20b1YKrR+C3vN0m3inkjDOEDph5PpTOeuQ6l+bd0ZYbbjRTrHCANdR 484RTut0sMys0rsATHfejA1ljQUibK6bM2uUdT9Y4yRmW1wlfoLMaOMvvbUu3gHqOJc5 hwD8fxxZ7MPvjhFSmZ+qeXoH0PlQQLOAoYHdoBjr/qjoFJgjVT0rPecmi16jZmbi2Urm gfcFyk/e6vNz/2PK0Af9bObtbrbldADeoNdHA8FO5L2NgvDNlUW0fpJ28t/nMVH6E927 xTOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696994909; x=1697599709; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5kL0i+lvGxYVm5/EfnWo2tpujMq+OvDoFyDLAloC0WE=; b=YleRFoz2fSPLYkJQLiyUSymg4j/8yj83tRJS4RnpScEtUC5v1jybk2JKF1wRiwBaWr KVxCo9uP1VwtPP2/zcvCSUjf/BaMTBlfskt2W43QkYKZl+hBQSkUwZ9gA3Dag7yto2rC BPwgLZV3XZsX8nnenCKcIm34IMLamX/eSgl6AFbXbLZmNVgT/VG+G+6ZaT0IpE11ruJF CHpks8LZeiqy0CLUEGJ2HEi8AWTu+1+auKuor3GPRV1zxoheu+G/iWJHVWld1AxYWWOH SN3fqMkW5QsB7a1bWOYtQYr040N1OsZ1AQVGSMAdmO41WuEW1+w+BzRmXaRSLgWc6uLH mC8g== X-Gm-Message-State: AOJu0Yyfv2t9cIYwXJsm3S9aFXzlxzHk1182WTbJEynsaLqhW4KHDwPG mtV9rA2aEcspgpzqNTQSex44NtlIg/g= X-Google-Smtp-Source: AGHT+IHeHR/CqLPR5ERLvyF8UhuPMDhgz/F5XMcUs3YkevyKDNLAJhecyGfvk9loFRccPKjunzszkQ== X-Received: by 2002:a25:add7:0:b0:d82:d72c:ed70 with SMTP id d23-20020a25add7000000b00d82d72ced70mr17844765ybe.36.1696994908832; Tue, 10 Oct 2023 20:28:28 -0700 (PDT) Received: from [192.168.1.66] (104-55-12-234.lightspeed.knvltn.sbcglobal.net. [104.55.12.234]) by smtp.gmail.com with ESMTPSA id g61-20020a25a4c3000000b00d8168e226e6sm4251106ybi.47.2023.10.10.20.28.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Oct 2023 20:28:27 -0700 (PDT) Message-ID: Date: Tue, 10 Oct 2023 23:28:26 -0400 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: 26103ccba8b7 - main - zfs: enable block cloning by default To: Ravi Pokala , Martin Matuska , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202310102247.39AMlsjX018898@gitrepo.freebsd.org> <2D247230-D189-4A43-85A2-0F2442A9CA6A@panasas.com> Content-Language: en-US From: Alexander Motin In-Reply-To: <2D247230-D189-4A43-85A2-0F2442A9CA6A@panasas.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Queue-Id: 4S4ysV2QBWz3G80 Hi Ravi, It was disabled because 6 months ago when it was introduced there were some bug reports, and people preferred to stay away rather than debug it. Since then Linux support was added with respective testing and fixing. Several bugs found during FreeBSD testing were addressed, and all the tests are passing clean now. In upstream OpenZFS this feature was never actually disabled, and the release of OpenZFS 2.2.0 including it should be officially tagged nearest days. So we feel it is time for another try. At least until any other issues are reported, there is no reason for it to stay disabled. On 10.10.2023 22:44, Ravi Pokala wrote: > Hi Martin, > > The commit message says "what", not "why". > > Why was block cloning disabled by default before, and why is it being enabled now? > > Thanks, > > Ravi (rpokala@) > > -----Original Message----- > From: > on behalf of Martin Matuska > > Date: Wednesday, October 11, 2023 at 04:17 > To: >, >, > > Subject: git: 26103ccba8b7 - main - zfs: enable block cloning by default > > > The branch main has been updated by mm: > > > URL: https://cgit.FreeBSD.org/src/commit/?id=26103ccba8b75038bd83773268524ac814bfa334 > > > commit 26103ccba8b75038bd83773268524ac814bfa334 > Author: Martin Matuska > > AuthorDate: 2023-10-10 22:43:35 +0000 > Commit: Martin Matuska > > CommitDate: 2023-10-10 22:43:35 +0000 > > > zfs: enable block cloning by default > > > Discussed with: markj > Reviewed by: mav > Tested by: mm (FreeBSD test suite + OpenZFS test suite) > MFC after: 2 months > Differential Revision: https://reviews.freebsd.org/D41991 > --- > sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vfsops.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > > diff --git a/sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vfsops.c b/sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vfsops.c > index 8969fd6a54bd..09e18de81748 100644 > --- a/sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vfsops.c > +++ b/sys/contrib/openzfs/module/os/freebsd/zfs/zfs_vfsops.c > @@ -89,7 +89,7 @@ int zfs_debug_level; > SYSCTL_INT(_vfs_zfs, OID_AUTO, debug, CTLFLAG_RWTUN, &zfs_debug_level, 0, > "Debug level"); > > > -int zfs_bclone_enabled; > +int zfs_bclone_enabled = 1; > SYSCTL_INT(_vfs_zfs, OID_AUTO, bclone_enabled, CTLFLAG_RWTUN, > &zfs_bclone_enabled, 0, "Enable block cloning"); > > > > > > -- Alexander Motin