From owner-freebsd-net@FreeBSD.ORG Tue Mar 31 17:09:35 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 34DAD3D6; Tue, 31 Mar 2015 17:09:35 +0000 (UTC) Received: from mail.strugglingcoder.info (strugglingcoder.info [65.19.130.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 16BB7337; Tue, 31 Mar 2015 17:09:34 +0000 (UTC) Received: from localhost (unknown [10.1.1.3]) (Authenticated sender: hiren@strugglingcoder.info) by mail.strugglingcoder.info (Postfix) with ESMTPSA id A83BE1068C5; Tue, 31 Mar 2015 10:09:33 -0700 (PDT) Date: Tue, 31 Mar 2015 10:09:33 -0700 From: hiren panchasara To: Adrian Chadd Subject: Re: Full 32bit flowid from igb(4) Message-ID: <20150331170933.GK10892@strugglingcoder.info> References: <20150323233908.GT53237@strugglingcoder.info> <20150323234214.GU53237@strugglingcoder.info> <20150324154931.GC53237@strugglingcoder.info> <20150330225945.GI10892@strugglingcoder.info> <20150331050628.GJ10892@strugglingcoder.info> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="IA03tywDYuoVKXrw" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Cc: Jack F Vogel , FreeBSD Net , erj@freebsd.org, Jack Vogel , Jason Wolfe X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Mar 2015 17:09:35 -0000 --IA03tywDYuoVKXrw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 03/30/15 at 10:53P, Adrian Chadd wrote: > No, you're absolutely right. However, you (a) get flowid for L3/L4 > V4/v6 but not other things, and (b) I was worried about changing the > default behaviour of the driver, and who knows what other weird crap > people may have done to their local driver. stuff like enabled > checksums instead, or hacked in flowtable support. :) >=20 > So, I'm totally fine if you want to populate the flowid for a given > flow. Totally okay. You just can't set it blindly - you can only set > it when the relevant descriptor bits say "it's a flowid!". Thanks for taking time and answering. Totally agree. Looking at the code, igb does setup everything correctly to get RSS hash in flowid when num_queues > 1. I'm not sure and I've not checked what other chipsets do but I350 looks fine. If needed I am okay to guard this with mac_type check. Jack/Eric: Let me know what you guys think. Cheers, Hiren --IA03tywDYuoVKXrw Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (FreeBSD) iQF8BAEBCgBmBQJVGtTNXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNEUyMEZBMUQ4Nzg4RjNGMTdFNjZGMDI4 QjkyNTBFMTU2M0VERkU1AAoJEIuSUOFWPt/lVUsH/0rQirWlljyzZkN+nlCO59hK NErW1lRJtq1b7ztWQjqWc3VDvCmYdoBAZksEPWm3nQoc6MgNYWLdNkm5zjbudbOh 8Q9+TSCberuS3RlZdM2eCppUuDtm68Uq6Zc8dTfjhWsZ6M5V5jwRMkhN9qRF7i0Y gVYA4eh0f0qyeIS0wc3wMi06ZjC6ve7zCSZk11i0knrX0kLAyEPyzilF1b+286IU nrcp0I55eLFy4X2cnTq/JWMWpjOf014468fhFS0VtPSF1wckTvlG3vvfz6LHRFMm LsAyai+mlTx05xIRrtFYA7LMwEepRnLVUM0WxlBEahMogsRFkzmhYXA5nSDg+zs= =wcC7 -----END PGP SIGNATURE----- --IA03tywDYuoVKXrw--