From owner-freebsd-current Tue Sep 15 21:28:47 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id VAA26545 for freebsd-current-outgoing; Tue, 15 Sep 1998 21:28:47 -0700 (PDT) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from gatekeeper.tsc.tdk.com (gatekeeper.tsc.tdk.com [207.113.159.21]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id VAA26534 for ; Tue, 15 Sep 1998 21:28:42 -0700 (PDT) (envelope-from gdonl@tsc.tdk.com) Received: from sunrise.gv.tsc.tdk.com (root@sunrise.gv.tsc.tdk.com [192.168.241.191]) by gatekeeper.tsc.tdk.com (8.8.8/8.8.8) with ESMTP id VAA06365; Tue, 15 Sep 1998 21:28:22 -0700 (PDT) (envelope-from gdonl@tsc.tdk.com) Received: from salsa.gv.tsc.tdk.com (salsa.gv.tsc.tdk.com [192.168.241.194]) by sunrise.gv.tsc.tdk.com (8.8.5/8.8.5) with ESMTP id VAA02946; Tue, 15 Sep 1998 21:28:20 -0700 (PDT) Received: (from gdonl@localhost) by salsa.gv.tsc.tdk.com (8.8.5/8.8.5) id VAA01166; Tue, 15 Sep 1998 21:28:18 -0700 (PDT) From: Don Lewis Message-Id: <199809160428.VAA01166@salsa.gv.tsc.tdk.com> Date: Tue, 15 Sep 1998 21:28:18 -0700 In-Reply-To: Don Lewis "New kernel compile warnings with CAM" (Sep 15, 6:19pm) X-Mailer: Mail User's Shell (7.2.6 alpha(3) 7/19/95) To: current@FreeBSD.ORG, gibbs@plutotech.com Subject: Re: New kernel compile warnings with CAM Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Sep 15, 6:19pm, Don Lewis wrote: } Subject: New kernel compile warnings with CAM } I got these warnings when compiling a kernel with recent sources. Some } of these look serious ... } } ../../cam/cam_xpt.c:5363: warning: too few arguments for format } ../../dev/aha/aha.c:516: warning: too few arguments for format } ../../dev/aha/aha.c:1014: warning: too few arguments for format } ../../dev/aha/aha.c:1142: warning: unsigned int format, pointer arg (arg 3) } ../../dev/aha/aha.c:1366: warning: format argument is not a pointer (arg 2) } ../../dev/aha/aha.c:1366: warning: too few arguments for format } ../../dev/aha/aha.c:1680: warning: unsigned int format, pointer arg (arg 2) } ../../dev/aha/aha.c:1686: warning: unsigned int format, pointer arg (arg 2) } ../../dev/aic7xxx/aic7xxx.c:1115: warning: unsigned int format, pointer arg (arg 2) } ../../dev/aic7xxx/aic7xxx.c:1749: warning: int format, pointer arg (arg 2) } ../../dev/aic7xxx/aic7xxx.c:1749: warning: format argument is not a pointer (arg 3) } ../../pci/ncr.c:5609: warning: long unsigned int format, nccb_p arg (arg 5) } ../../pci/ncr.c:6902: warning: long unsigned int format, unsigned int arg (arg 3) } ../../pci/ncr.c:6930: warning: long unsigned int format, unsigned int arg (arg 2) } ../../pci/ncr.c:6930: warning: long unsigned int format, unsigned int arg (arg 3) } ../../pci/pci.c:766: warning: long unsigned int format, pointer arg (arg 2) Most of these are harmless, but some could cause a panic. --- dev/aha/aha.c.orig Tue Sep 15 00:39:52 1998 +++ dev/aha/aha.c Tue Sep 15 21:13:26 1998 @@ -513,7 +513,8 @@ ahaallocccbs(aha); if (aha->num_ccbs == 0) { - printf("%s: aha_init - Unable to allocate initial ccbs\n"); + printf("%s: aha_init - Unable to allocate initial ccbs\n", + aha_name(aha)); goto error_exit; } @@ -1011,7 +1012,7 @@ if (error != 0) { if (error != EFBIG) printf("%s: Unexepected error 0x%x returned from " - "bus_dmamap_load\n", aha_name(aha)); + "bus_dmamap_load\n", aha_name(aha), error); if (ccb->ccb_h.status == CAM_REQ_INPROG) { xpt_freeze_devq(ccb->ccb_h.path, /*count*/1); ccb->ccb_h.status = CAM_REQ_TOO_BIG|CAM_DEV_QFRZN; @@ -1138,7 +1139,7 @@ csio = &bccb->ccb->csio; if ((bccb->flags & BCCB_ACTIVE) == 0) { - printf("%s: ahadone - Attempt to free non-active BCCB 0x%x\n", + printf("%s: ahadone - Attempt to free non-active BCCB %p\n", aha_name(aha), bccb); return; } @@ -1363,7 +1364,7 @@ if ((status & DATAIN_REG_READY) != 0) printf("%s: ahareset - Host Adapter Error code = 0x%x\n", - aha_inb(aha, DATAIN_REG)); + aha_name(aha), aha_inb(aha, DATAIN_REG)); return (ENXIO); } @@ -1677,13 +1678,13 @@ ccb = bccb->ccb; aha = (struct aha_softc *)ccb->ccb_h.ccb_aha_ptr; xpt_print_path(ccb->ccb_h.path); - printf("CCB 0x%x - timed out\n", bccb); + printf("CCB %p - timed out\n", bccb); s = splcam(); if ((bccb->flags & BCCB_ACTIVE) == 0) { xpt_print_path(ccb->ccb_h.path); - printf("CCB 0x%x - timed out CCB already completed\n", bccb); + printf("CCB %p - timed out CCB already completed\n", bccb); splx(s); return; } --- dev/aic7xxx/aic7xxx.c.orig Tue Sep 15 00:24:16 1998 +++ dev/aic7xxx/aic7xxx.c Tue Sep 15 21:16:10 1998 @@ -1112,7 +1112,7 @@ * to this accept tio. */ xpt_print_path(atio->ccb_h.path); - printf("Incoming Command did not disconnect %x\n", lstate); + printf("Incoming Command did not disconnect %p\n", lstate); ahc->pending_device = lstate; } xpt_done((union ccb*)atio); @@ -1745,8 +1745,8 @@ case MSG_ABORT: xpt_print_path(scb->ccb->ccb_h.path); printf("SCB %d - Abort %s Completed.\n", - tag == SCB_LIST_NULL ? "" : "Tag", - scb->hscb->tag); + scb->hscb->tag, + tag == SCB_LIST_NULL ? "" : "Tag"); if ((scb->flags & SCB_RECOVERY_SCB) != 0) { ahc_set_ccb_status(scb->ccb, CAM_REQ_ABORTED); To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message