From owner-freebsd-usb@FreeBSD.ORG  Sun Feb  1 18:36:24 2009
Return-Path: <owner-freebsd-usb@FreeBSD.ORG>
Delivered-To: freebsd-usb@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 3AA981065670;
	Sun,  1 Feb 2009 18:36:24 +0000 (UTC)
	(envelope-from hselasky@c2i.net)
Received: from swip.net (mailfe13.swipnet.se [212.247.155.129])
	by mx1.freebsd.org (Postfix) with ESMTP id 993E48FC21;
	Sun,  1 Feb 2009 18:36:23 +0000 (UTC)
	(envelope-from hselasky@c2i.net)
X-Cloudmark-Score: 0.000000 []
X-Cloudmark-Analysis: v=1.0 c=1 a=ACjjPeCvvAMhK6rthv0A:9
	a=86F4ak1v-r6RfpvaW6IA:7 a=8wFUjE_z0-u8Gx49E20BxLkqJrwA:4
	a=9aOQ2cSd83gA:10 a=LY0hPdMaydYA:10
Received: from [85.19.218.115] (account mc467741@c2i.net HELO [10.37.1.92])
	by mailfe13.swip.net (CommuniGate Pro SMTP 5.2.6)
	with ESMTPA id 799659041; Sun, 01 Feb 2009 19:36:22 +0100
From: Hans Petter Selasky <hselasky@c2i.net>
To: "M. Warner Losh" <imp@bsdimp.com>
Date: Sun, 1 Feb 2009 19:38:47 +0100
User-Agent: KMail/1.9.7
References: <200902011220.18745.hselasky@c2i.net>
	<200902011922.16810.hselasky@c2i.net>
	<20090201.112756.1320088159.imp@bsdimp.com>
In-Reply-To: <20090201.112756.1320088159.imp@bsdimp.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200902011938.48670.hselasky@c2i.net>
Cc: freebsd-usb@freebsd.org, thompsa@freebsd.org
Subject: Re: USB2 patches
X-BeenThere: freebsd-usb@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: FreeBSD support for USB <freebsd-usb.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-usb>,
	<mailto:freebsd-usb-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-usb>
List-Post: <mailto:freebsd-usb@freebsd.org>
List-Help: <mailto:freebsd-usb-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-usb>,
	<mailto:freebsd-usb-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 01 Feb 2009 18:36:24 -0000

On Sunday 01 February 2009, M. Warner Losh wrote:
> In message: <200902011922.16810.hselasky@c2i.net>
>
>             Hans Petter Selasky <hselasky@c2i.net> writes:
> : In your patch you remove all error checking! If the taskqueue system does
> : not have an API function that can tell if the taskqueue is being drained
> : from inside the taskqueue callback, the taskqueue system has to be
> : modified! It cannot replace the existing system like it is now!
>
> Why does the taskqueue system need to provide that?  Why can't the
> driver set a dying flag in the softc to communicate this fact to the
> taskqueue tasks?

That's also possible. Thomas already made a "struct usb2_task" I think, where 
this flag could be added.

--HPS