From owner-cvs-ports@FreeBSD.ORG Tue Dec 6 21:09:57 2005 Return-Path: X-Original-To: cvs-ports@FreeBSD.org Delivered-To: cvs-ports@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7D83B16A41F; Tue, 6 Dec 2005 21:09:57 +0000 (GMT) (envelope-from flz@FreeBSD.org) Received: from smtp.xbsd.org (xbsd.org [82.233.2.192]) by mx1.FreeBSD.org (Postfix) with ESMTP id B8AFE43D73; Tue, 6 Dec 2005 21:09:55 +0000 (GMT) (envelope-from flz@FreeBSD.org) Received: from localhost (localhost.xbsd.org [127.0.0.1]) by smtp.xbsd.org (Postfix) with ESMTP id 7AD5311962; Tue, 6 Dec 2005 22:09:51 +0100 (CET) Received: from smtp.xbsd.org ([127.0.0.1]) by localhost (srv1.xbsd.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 00348-10; Tue, 6 Dec 2005 22:09:41 +0100 (CET) Received: from cream.xbsd.org (cream.xbsd.org [192.168.42.6]) by smtp.xbsd.org (Postfix) with ESMTP id 572681141F; Tue, 6 Dec 2005 22:09:41 +0100 (CET) From: Florent Thoumie To: obrien@FreeBSD.org In-Reply-To: <20051206201757.GA3970@dragon.NUXI.org> References: <200511301510.jAUFACmr038837@repoman.freebsd.org> <20051130161657.GA65549@FreeBSD.org> <1133371126.1219.23.camel@cream.xbsd.org> <20051130183717.GA71920@xor.obsecurity.org> <1133380999.1219.30.camel@cream.xbsd.org> <20051205093626.GA68544@dragon.NUXI.org> <1133782867.879.3.camel@cream.xbsd.org> <20051206201757.GA3970@dragon.NUXI.org> Content-Type: text/plain; charset=utf-8 Date: Tue, 06 Dec 2005 22:08:49 +0000 Message-Id: <1133906929.679.2.camel@cream.xbsd.org> Mime-Version: 1.0 X-Mailer: Evolution 2.4.2 FreeBSD GNOME Team Port Content-Transfer-Encoding: 8bit X-Virus-Scanned: amavisd-new at xbsd.org Cc: cvs-ports@FreeBSD.org, Alexey Dokuchaev , ports-committers@FreeBSD.org, cvs-all@FreeBSD.org, Kris Kennaway Subject: Re: cvs commit: ports/shells/bash Makefile X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Dec 2005 21:09:57 -0000 Le Mardi 06 décembre 2005 à 12:17 -0800, David O'Brien a écrit : > On Mon, Dec 05, 2005 at 11:41:07AM +0000, Florent Thoumie wrote: > > Le Lundi 05 décembre 2005 à 01:36 -0800, David O'Brien a écrit : > > > On Wed, Nov 30, 2005 at 08:03:19PM +0000, Florent Thoumie wrote: > > > > Le Mercredi 30 novembre 2005 à 13:37 -0500, Kris Kennaway a écrit : > > > > > Don't commit bogus changes, and > > > > > > > > > > > 2) shells/bash2 has the same exact construction. > > > > > > > > > > fix bogus changes when you encounter them. > > > > > > > > I'll send a PR with s/WANT/WITH/ later and will commit the fix > > > > in two weeks with maintainer timeout. > > > > > > *sigh* why all the overhead? Since you're already in the middle of this > > > issue, please make it right for our users and just commit the fixed > > > version now. > > > > I'm fine with people fixing my mistakes, but that's not > > something I would assume for every maintainer, so I just wanted > > to ask in the first place. > > I guess I have the opposite thinking :-) - once you start commiting a > change you're responsible for seeing it thru into proper shape if the > first commit had issues. That's right (for shell/bash in that case), but I wouldn't touch shell/bash2 without your approval or a two weeks period of inactivity (after notification). Anyway, that's fixed now, let's go fixing something else :-) -- Florent Thoumie flz@FreeBSD.org FreeBSD committer