From owner-cvs-all Tue May 22 19: 7:51 2001 Delivered-To: cvs-all@freebsd.org Received: from dt051n37.san.rr.com (dt051n37.san.rr.com [204.210.32.55]) by hub.freebsd.org (Postfix) with ESMTP id B040537B424; Tue, 22 May 2001 19:07:46 -0700 (PDT) (envelope-from DougB@DougBarton.net) Received: from DougBarton.net (master [10.0.0.2]) by dt051n37.san.rr.com (8.9.3/8.9.3) with ESMTP id TAA99092; Tue, 22 May 2001 19:07:45 -0700 (PDT) (envelope-from DougB@DougBarton.net) Message-ID: <3B0B1B70.CA534B97@DougBarton.net> Date: Tue, 22 May 2001 19:07:44 -0700 From: Doug Barton Organization: Triborough Bridge & Tunnel Authority X-Mailer: Mozilla 4.77 [en] (X11; U; Linux 2.2.12 i386) X-Accept-Language: en MIME-Version: 1.0 To: Robert Watson Cc: Warner Losh , Matt Dillon , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_prot.c src/sys/sys ucred.h References: Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Robert Watson wrote: > > On Thu, 17 May 2001, Warner Losh wrote: > > > In message Robert Watson writes: > > : Note that this may break binary compatibility for kernel modules that > > : relied on the existing crhold() macro. As such, this probably needs a > > : warning in UPDATING that modules must be recompiled, especially since this > > : is in -STABLE. > > > > You are right, but any idea if such modules exist? > > Hmm. Well, credential references are manipulated by at least the NFS and > SMBfs code, but I haven't really looked into much more detail. I haven't > figured out the byte order issues, but it may be this has different > effects on different platforms. I'd just give a general note of caution. > I think having the cr_ref updating in -STABLE is great, we just need to be > careful. Umm.... isn't this the kind of change we shouldn't do in -stable, especially if we're not sure whethere there are 3rd party modules that use it? Maybe I'm missing something here.... -- I need someone really bad. Are you really bad? To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message