From owner-freebsd-arch Sun May 7 4: 0:59 2000 Delivered-To: freebsd-arch@freebsd.org Received: from freebie.lemis.com (freebie.lemis.com [192.109.197.137]) by hub.freebsd.org (Postfix) with ESMTP id 28DB337B6A6; Sun, 7 May 2000 04:00:46 -0700 (PDT) (envelope-from grog@freebie.lemis.com) Received: (from grog@localhost) by freebie.lemis.com (8.9.3/8.9.0) id UAA57464; Sun, 7 May 2000 20:29:44 +0930 (CST) Date: Sun, 7 May 2000 20:29:44 +0930 From: Greg Lehey To: Poul-Henning Kamp Cc: "Justin T. Gibbs" , FreeBSD-arch@FreeBSD.ORG Subject: Re: Support for bootable Vinum file systems: please review Message-ID: <20000507202944.I55316@freebie.lemis.com> References: <20000507174638.E55316@freebie.lemis.com> <12215.957694109@critter.freebsd.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 1.0pre2i In-Reply-To: <12215.957694109@critter.freebsd.dk> Organization: LEMIS, PO Box 460, Echunga SA 5153, Australia Phone: +61-8-8388-8286 Fax: +61-8-8388-8725 Mobile: +61-418-838-708 WWW-Home-Page: http://www.lemis.com/~grog X-PGP-Fingerprint: 6B 7B C3 8C 61 CD 54 AF 13 24 52 F8 6D A4 95 EF Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Sunday, 7 May 2000 at 12:08:29 +0200, Poul-Henning Kamp wrote: > In message <20000507174638.E55316@freebie.lemis.com>, Greg Lehey writes: >> On Friday, 5 May 2000 at 12:52:33 +0200, Poul-Henning Kamp wrote: >>> >>>> I've been testing vinum root file systems for a couple of months now, >>>> and I'd like to commit the code. I'm attaching the patches, which you >>>> can also access at http://www.FreeBSD.org/~grog/vinum-root.html. >>> >>> It looks good, but I think using devstat to find possible disks is >>> wrong. >>> >>> The right way to do it is probably to link the "struct disk"s >>> registered by the drivers with disk_creat() into a list which can >>> be searched. >> >> This is pretty much what struct devstat does, except that it's more >> global. Why should we maintain two lists, just because one is >> primarily intended for statistics? >> >> Anyway, I assume this isn't so much a criticism of the fix as of the >> infrastructure around it. Correct? > > No, this is an objection to opening up devstat that way. Can you make an alternative suggestion? Greg -- Finger grog@lemis.com for PGP public key See complete headers for address and phone numbers To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message