From owner-freebsd-current@FreeBSD.ORG  Sat Jul 15 03:20:22 2006
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: freebsd-current@freebsd.org
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 7EABE16A4DA;
	Sat, 15 Jul 2006 03:20:22 +0000 (UTC)
	(envelope-from sanewo@ba2.so-net.ne.jp)
Received: from mx52.ms.so-net.ne.jp (mx52.ms.so-net.ne.jp [202.238.83.2])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 0964543D46;
	Sat, 15 Jul 2006 03:20:21 +0000 (GMT)
	(envelope-from sanewo@ba2.so-net.ne.jp)
Received: from [127.0.0.1] (p629977.tkyoac00.ap.so-net.ne.jp [219.98.153.119])
	by mx52.ms.so-net.ne.jp  with ESMTP id k6F3JOm5020086;
	Sat, 15 Jul 2006 12:19:46 +0900 (JST)
Message-ID: <44B85EBA.3080207@ba2.so-net.ne.jp>
Date: Sat, 15 Jul 2006 12:19:22 +0900
From: SANETO Takanori <sanewo@ba2.so-net.ne.jp>
User-Agent: Thunderbird 1.5.0.4 (Windows/20060516)
MIME-Version: 1.0
To: John Baldwin <jhb@freebsd.org>
References: <c21e92e20607110629t490a7abv1cd6f4eb84f19e66@mail.gmail.com>
	<200607111101.47747.jhb@freebsd.org>
In-Reply-To: <200607111101.47747.jhb@freebsd.org>
X-Enigmail-Version: 0.94.0.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: bp@freebsd.org, freebsd-current@freebsd.org,
	Jiawei Ye <leafy7382@gmail.com>
Subject: Re: lockmgr: thread 0xc21e2780 unlocking unheld lock
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 15 Jul 2006 03:20:22 -0000

I think that "==" should be "!=" in the patched code.

John Baldwin wrote:
> On Tuesday 11 July 2006 09:29, Jiawei Ye wrote:
>> I was doing "sudo mount_smbfs //user@server/share /mnt" when the
>> following msg appeared. smbfs.ko was not loaded.
> 
> Does building with INVARIANTS fix it?  If so, try this patch (it looks
> like it has been broken since 1.1 of the smbfs code):
> 
> Index: smb_conn.c
> ===================================================================
> RCS file: /usr/cvs/src/sys/netsmb/smb_conn.c,v
> retrieving revision 1.16
> diff -u -r1.16 smb_conn.c
> --- smb_conn.c	31 Oct 2005 15:41:27 -0000	1.16
> +++ smb_conn.c	11 Jul 2006 15:01:10 -0000
> @@ -233,7 +233,8 @@
>  	lockinit(&cp->co_lock, PZERO, objname, 0, 0);
>  	cp->co_level = level;
>  	cp->co_usecount = 1;
> -	KASSERT(smb_co_lock(cp, LK_EXCLUSIVE, td) == 0, ("smb_co_init: lock 
> failed"));
> +	if (smb_co_lock(cp, LK_EXCLUSIVE, td) == 0)
> +	    panic("smb_co_init: lock failed"));
>  }
>  
>  static void
>