From owner-freebsd-emulation@FreeBSD.ORG  Sun Mar 16 21:07:08 2014
Return-Path: <owner-freebsd-emulation@FreeBSD.ORG>
Delivered-To: emulation@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id CD9AA57C
 for <emulation@FreeBSD.org>; Sun, 16 Mar 2014 21:07:08 +0000 (UTC)
Received: from mx1a.lautre.net (eyra.lautre.net [80.67.160.71])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 89744344
 for <emulation@FreeBSD.org>; Sun, 16 Mar 2014 21:07:08 +0000 (UTC)
Received: from graf.pompo.net (unknown [78.225.128.39])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 (Authenticated sender: thierry@pompo.net)
 by mx1a.lautre.net (Postfix) with ESMTPSA id 5ECF740E00;
 Sun, 16 Mar 2014 22:07:06 +0100 (CET)
Received: by graf.pompo.net (Postfix, from userid 1001)
 id D7E9D71E58E; Sun, 16 Mar 2014 22:07:05 +0100 (CET)
Date: Sun, 16 Mar 2014 22:07:05 +0100
From: Thierry Thomas <thierry@FreeBSD.org>
To: Alexander Leidinger <Alexander@Leidinger.net>
Subject: Re: Mk/bsd.linux-rpm.mk does not allow grouping rules (:something)
Message-ID: <20140316210705.GJ15009@graf.pompo.net>
References: <20140212201524.8192371E4AF@graf.pompo.net>
 <20140316185515.00006495@unknown>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20140316185515.00006495@unknown>
X-Operating-System: FreeBSD 10.0-STABLE amd64
Organization: Kabbale Eros
X-Face: (hRbQnK~Pt7$ct`!fupO(`y_WL4^-Iwn4@ly-.,[4xC4xc;
 y=\ipKMNm<1J>lv@PP~7Z<.t KjAnXLs:
X-PGP: 0xF1C516B3C8359753
User-Agent: Mutt/1.5.22 (2013-10-16)
Cc: emulation@FreeBSD.org
X-BeenThere: freebsd-emulation@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Development of Emulators of other operating systems
 <freebsd-emulation.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-emulation>, 
 <mailto:freebsd-emulation-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-emulation/>
List-Post: <mailto:freebsd-emulation@freebsd.org>
List-Help: <mailto:freebsd-emulation-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-emulation>, 
 <mailto:freebsd-emulation-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 16 Mar 2014 21:07:08 -0000

Le dim 16 mar 14 à 18:55:15 +0100, Alexander Leidinger <Alexander@Leidinger.net>
 écrivait :
> On Wed, 12 Feb 2014 21:15:24 +0100 (CET)
> Thierry Thomas <thierry@FreeBSD.org> wrote:
> 
> > >Synopsis:	Mk/bsd.linux-rpm.mk does not allow grouping rules
> > >(:something)
> [...]
> > >Fix:
> > 	Please apply this patch:
> > 
> > --- bsd.linux-rpm.mk.diff begins here ---
> > --- Mk/bsd.linux-rpm.mk.orig	2014-01-21 21:18:37.000000000
> > +0100 +++ Mk/bsd.linux-rpm.mk	2014-02-12 21:03:50.000000000
> > +0100 @@ -95,7 +95,7 @@
> >  # is not true.
> >  
> >  DISTFILES?=		${DISTNAME}${EXTRACT_SUFX}
> > -BIN_DISTFILES:=		${DISTFILES}
> > +BIN_DISTFILES:=		${_DISTFILES}
> >  SRC_DISTFILES?=		${DISTNAME}${SRC_SUFX}
> >  EXTRACT_ONLY?=		${BIN_DISTFILES}
> 
> This is all what is needed to make this work? Did you test this with
> some linux ports (e.g. linux_base)?

Seems so!

> If you have tested and there is no fallout, I have no objections.
> If you haven't tested a lot I recommend to test (if in doubt, an
> exp-run, else a representative list of ports and a commitment to fix
> reports of broken ports).

I have tested the proposed patch with the port devel/linux-f10-devtools
(the used patch is included in the PR, paragraph "How-To-Repeat"), but I
have not tested it against other ports.

In this case, an exp-run is not very useful: if you only apply the patch
to Mk/bsd.linux-rpm.mk, anything is modified. To see the change, the
other linux ports have to use the groups.

I'll do the test for emulators/linux_base-f10 and some others, and will
post the results here.

Best regards,
-- 
Th. Thomas.