From owner-svn-src-head@FreeBSD.ORG Fri Oct 12 04:55:31 2012 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id CD221374; Fri, 12 Oct 2012 04:55:31 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebius.int.ru (glebius.int.ru [81.19.64.117]) by mx1.freebsd.org (Postfix) with ESMTP id 443768FC12; Fri, 12 Oct 2012 04:55:31 +0000 (UTC) Received: from cell.glebius.int.ru (localhost [127.0.0.1]) by cell.glebius.int.ru (8.14.5/8.14.5) with ESMTP id q9C4tU6U098645; Fri, 12 Oct 2012 08:55:30 +0400 (MSK) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebius.int.ru (8.14.5/8.14.5/Submit) id q9C4tU4t098644; Fri, 12 Oct 2012 08:55:30 +0400 (MSK) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Fri, 12 Oct 2012 08:55:30 +0400 From: Gleb Smirnoff To: Kevin Lo Subject: Re: svn commit: r241471 - head/share/man/man9 Message-ID: <20121012045530.GK89655@FreeBSD.org> References: <201210120131.q9C1V3jM018799@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <201210120131.q9C1V3jM018799@svn.freebsd.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Oct 2012 04:55:31 -0000 On Fri, Oct 12, 2012 at 01:31:03AM +0000, Kevin Lo wrote: K> Author: kevlo K> Date: Fri Oct 12 01:31:02 2012 K> New Revision: 241471 K> URL: http://svn.freebsd.org/changeset/base/241471 K> K> Log: K> Since the moduledata structure member priv is a void pointer, using K> NULL instead of 0 when dealing with pointers. K> K> Modified: K> head/share/man/man9/module.9 K> K> Modified: head/share/man/man9/module.9 K> ============================================================================== K> --- head/share/man/man9/module.9 Thu Oct 11 23:41:18 2012 (r241470) K> +++ head/share/man/man9/module.9 Fri Oct 12 01:31:02 2012 (r241471) K> @@ -99,7 +99,7 @@ static int foo_handler(module_t mod, int K> static moduledata_t mod_data= { K> "foo", K> foo_handler, K> - 0 K> + NULL K> }; K> K> MODULE_VERSION(foo, 1); I think we should provide C99 sparse initializers for structures in all manpages in section 9, as well as use only such initializers in any new code added to tree. -- Totus tuus, Glebius.