From nobody Wed Aug 27 08:01:49 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cBcSM2h9zz65tst; Wed, 27 Aug 2025 08:01:55 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cBcSL67pSz3Bs3; Wed, 27 Aug 2025 08:01:54 +0000 (UTC) (envelope-from bz@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1756281714; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YdLU09IkxAKVw6BuWFGGanRONBbFI8OztKOKD4GXetI=; b=pHANeIjla6+CQUuzGscRaOxmulT9/nlsKXLttJv9aWnbDJeaahmemUSHzHeoaVzVe8yTyU WlWLmo7goyBmhoVNLjTDn153hymVZHcAbUpLr009gZ9xTJ+jaD+Bu72UDBYgRCW3iUBvUu 4zHZKWzaHWo8QdcrOxgYop9fhvztDTv/QRNT5vhpfa5h19wAuOW8D6wTph2xqGB6y364lW hP0yELzQTtttaYnUj8/BKL3+yOqzsAgng9qQhQkwAganjXFpq0DE0YBM4iGDIN9O3dl1uk Pvb+FsXirhTTVK1IAY11z6dOg0oaOSegGSWvWZ3xLhPlZi/jBqBf7Q5KlNbE7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1756281714; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YdLU09IkxAKVw6BuWFGGanRONBbFI8OztKOKD4GXetI=; b=broZv5I9XVHiwb5XCFeBTjXuJcN8jU6i1QSvUibm71rGKNLo7PoNeYkjkUJiaqDeMy/lO+ 8u0jQMHlu2vw7dVF+6rvIUTKL9lnYAgUz28DB0r0GuYTjQVETcCUc3AUJm/DIO0dzIVl1a tkuMb0E+iXxPs8bgInQupwD8fqkFows8ts3IgQH0tZFlC+H2WRA0UMpIJlPsHf7nVkUi0/ VLuUYQyniZQ3Ml4xFUZqAOSIY9/GxJVgBgU0l4cKyl5Q6S4UmzLpdzWUcm9xjpq1zpfCCV ijAm7+784vS/E5+fEl5OMpcwh9tWISaEz6ZjCyjqHU0QeSka53EiraqlsTEB5w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1756281714; a=rsa-sha256; cv=none; b=qxqxhtpsVRpbYDFdHMcm+dKl7uxJNBr7+4XVv/hnx/DsFjIachDAHZFCyRcSlD3o/EPz/E NxKX4QYCRN/MSSY0MRQnXsDjNAPYbZxpVLxe3G3dQW5/ElzemlU1V7gO4CaGmFj5X5flql 26kJ8NokGQcXIT4vHY2BK4yE0OEHuqxm5oBRUsk1Emzc+lwJi3RO1B9SD1v/TlUvRwsUNp Y0Vw0i+eSkl1a4Se+0I6NHI9rhXT3n8dCsFFRF7GvF7QO9doVrni30GYJikwo09ssjsLKS u7vFJ9CifI19EKgmdsa0Nxxp85IxmhcVM69lTYOGEuPZqw0uMsVAobFs9rnreQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from mx-01.divo.sbone.de (mx-01.divo.sbone.de [IPv6:2003:a:140a:2200:6:594:fffe:19]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature ECDSA (prime256v1) client-digest SHA256) (Client CN "mx-01.divo.sbone.de", Issuer "E6" (verified OK)) (Authenticated sender: bz/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4cBcSL48gxz1BT1; Wed, 27 Aug 2025 08:01:54 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by mx-01.divo.sbone.de (Postfix) with ESMTPS id EBDA2A64805; Wed, 27 Aug 2025 08:01:44 +0000 (UTC) Received: from content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id E33392D029E3; Wed, 27 Aug 2025 08:01:51 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) by content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (amavisd-new, port 10024) with ESMTP id JGnSNz1va_hV; Wed, 27 Aug 2025 08:01:50 +0000 (UTC) Received: from strong-iwl0.sbone.de (strong-iwl0.sbone.de [IPv6:fde9:577b:c1a9:4902:a66b:b6ff:fe40:39a9]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id 03B922D029D8; Wed, 27 Aug 2025 08:01:49 +0000 (UTC) Date: Wed, 27 Aug 2025 08:01:49 +0000 (UTC) From: "Bjoern A. Zeeb" To: ShengYi Hung cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 2b74ff5fceb6 - main - ichwd: introduce i6300esbwd watch dog driver In-Reply-To: <202508251545.57PFjqtI092750@gitrepo.freebsd.org> Message-ID: <55sn92r5-n62o-61s0-1s88-s2085o20q645@SerrOFQ.bet> References: <202508251545.57PFjqtI092750@gitrepo.freebsd.org> X-OpenPGP-Key-Id: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed On Mon, 25 Aug 2025, ShengYi Hung wrote: > The branch main has been updated by aokblast: > > URL: https://cgit.FreeBSD.org/src/commit/?id=2b74ff5fceb6623f6114ce39baee9f6ec5f79277 > > commit 2b74ff5fceb6623f6114ce39baee9f6ec5f79277 > Author: ShengYi Hung > AuthorDate: 2025-08-22 14:55:45 +0000 > Commit: ShengYi Hung > CommitDate: 2025-08-25 15:45:24 +0000 > > ichwd: introduce i6300esbwd watch dog driver > > The intel 6300ESB watchdog is a special ICH-based watchdog device with a > different interface. > QEMU implements this watchdog for x86 systems. > > This change enables watchdog mode (rather than free-running mode) and > introduces 1 sysctl: > - hw.i6300esbwd.0.locked: locks the watchdog register after the event is > triggered, preventing it from being disabled until a hard reset. > > This feature has been tested on a Vultr AMD guest machine and local qemu > machine. > > PR: 259673 > Approved by: markj (mentor), lwhsu (mentor) > MFC after: 2 weeks > Sponsored by: The FreeBSD Foundation > Differential Revision: https://reviews.freebsd.org/D52049 > --- > sys/conf/files.x86 | 1 + > sys/dev/ichwd/i6300esbwd.c | 245 +++++++++++++++++++++++++++++++++++++++++++++ > sys/dev/ichwd/i6300esbwd.h | 46 +++++++++ > sys/dev/ichwd/ichwd.c | 2 +- > sys/dev/ichwd/ichwd.h | 3 +- > sys/modules/ichwd/Makefile | 2 +- > 6 files changed, 296 insertions(+), 3 deletions(-) Compiling GENERIC I see: /sys/dev/ichwd/i6300esbwd.c:49:1: warning: unused function 'i6300esbwd_cfg_read' [-Wunused-function] 49 | i6300esbwd_cfg_read(struct i6300esbwd_softc *sc) | ^~~~~~~~~~~~~~~~~~~ Is it needed or can it be removed? -- Bjoern A. Zeeb r15:7