From owner-freebsd-current@freebsd.org Sat May 9 21:02:26 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5D3482F5B99 for ; Sat, 9 May 2020 21:02:26 +0000 (UTC) (envelope-from agapon@gmail.com) Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49KKQT26lgz4Kv4 for ; Sat, 9 May 2020 21:02:25 +0000 (UTC) (envelope-from agapon@gmail.com) Received: by mail-lj1-f175.google.com with SMTP id h4so5346938ljg.12 for ; Sat, 09 May 2020 14:02:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=ChQkNQvIa+qVS269pcDtt+L6W9RTlEksgi9d1Re6OOA=; b=hAsg1T38AXh8pl9lS8lcLwClMsjtein+FfOCIYVxpYwdpsW02A5ds8cf75Va24sijo 2vzbhIqHZDkjPUNrbyEGTbOYwRQHxdHowQSwQ6ZSwDEMg3cmJG8Zq9x5hAQXtMTzL8LE VNeQ/HQYtqc3bvXi0m9bsY2R68v0x1niuP4UNCZMk7C8cGpgTCmwgqObsHaD/HKKDWYo axEpMv/Ott3lCzM3wH8sEKsau85YJ5tOPs80+g+lYnkMUDx59qP7GeafqcCtpV68cp9C ElvKFRFD591/+ZKg87mTNnikRUNlv+lc/uzZPSKU+w+pMtHZX+DPAzAkxBglnqXBQFq4 DmAA== X-Gm-Message-State: AOAM5301l/UXfnUKb8OuyYrQqMk66ZCh/2/noozeqoGK2wpnWdo9qGeI fQLFeYbxQ+wYqQqIEnoQpFwQQ73xaJo= X-Google-Smtp-Source: ABdhPJworvn3isdv7hnzDnMVD0VcnHUW3YL/85VeNI6H7YymIoszIS3TM4pq5hX7kmJtmH1ZT+uJRQ== X-Received: by 2002:a2e:8752:: with SMTP id q18mr5602750ljj.72.1589058142998; Sat, 09 May 2020 14:02:22 -0700 (PDT) Received: from [192.168.0.88] (east.meadow.volia.net. [93.72.151.96]) by smtp.googlemail.com with ESMTPSA id q21sm5409066lfe.0.2020.05.09.14.02.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 09 May 2020 14:02:22 -0700 (PDT) Subject: Re: CHANGE_PV_LIST_LOCK_TO_PHYS is not correct when !NUMA ? To: Konstantin Belousov Cc: FreeBSD Current References: <0d7db402-621e-cc6b-2918-2078f63e2a9b@FreeBSD.org> <20200508161500.GC44519@kib.kiev.ua> <6485ab77-a3d0-8916-9431-74e4da1e3ea7@FreeBSD.org> <20200509161325.GH44519@kib.kiev.ua> <20200509165010.GI44519@kib.kiev.ua> <88ebc8f9-b10d-366d-a12a-fb74417904bc@FreeBSD.org> <20200509204743.GA68906@kib.kiev.ua> From: Andriy Gapon Openpgp: preference=signencrypt Autocrypt: addr=avg@FreeBSD.org; prefer-encrypt=mutual; keydata= mQINBFm4LIgBEADNB/3lT7f15UKeQ52xCFQx/GqHkSxEdVyLFZTmY3KyNPQGBtyvVyBfprJ7 mAeXZWfhat6cKNRAGZcL5EmewdQuUfQfBdYmKjbw3a9GFDsDNuhDA2QwFt8BmkiVMRYyvI7l N0eVzszWCUgdc3qqM6qqcgBaqsVmJluwpvwp4ZBXmch5BgDDDb1MPO8AZ2QZfIQmplkj8Y6Z AiNMknkmgaekIINSJX8IzRzKD5WwMsin70psE8dpL/iBsA2cpJGzWMObVTtCxeDKlBCNqM1i gTXta1ukdUT7JgLEFZk9ceYQQMJJtUwzWu1UHfZn0Fs29HTqawfWPSZVbulbrnu5q55R4PlQ /xURkWQUTyDpqUvb4JK371zhepXiXDwrrpnyyZABm3SFLkk2bHlheeKU6Yql4pcmSVym1AS4 dV8y0oHAfdlSCF6tpOPf2+K9nW1CFA8b/tw4oJBTtfZ1kxXOMdyZU5fiG7xb1qDgpQKgHUX8 7Rd2T1UVLVeuhYlXNw2F+a2ucY+cMoqz3LtpksUiBppJhw099gEXehcN2JbUZ2TueJdt1FdS ztnZmsHUXLxrRBtGwqnFL7GSd6snpGIKuuL305iaOGODbb9c7ne1JqBbkw1wh8ci6vvwGlzx rexzimRaBzJxlkjNfMx8WpCvYebGMydNoeEtkWldtjTNVsUAtQARAQABtB5BbmRyaXkgR2Fw b24gPGF2Z0BGcmVlQlNELm9yZz6JAlQEEwEIAD4WIQS+LEO7ngQnXA4Bjr538m7TUc1yjwUC WbgsiAIbIwUJBaOagAULCQgHAgYVCAkKCwIEFgIDAQIeAQIXgAAKCRB38m7TUc1yj+JAEACV l9AK/nOWAt/9cufV2fRj0hdOqB1aCshtSrwHk/exXsDa4/FkmegxXQGY+3GWX3deIyesbVRL rYdtdK0dqJyT1SBqXK1h3/at9rxr9GQA6KWOxTjUFURsU7ok/6SIlm8uLRPNKO+yq0GDjgaO LzN+xykuBA0FlhQAXJnpZLcVfPJdWv7sSHGedL5ln8P8rxR+XnmsA5TUaaPcbhTB+mG+iKFj GghASDSfGqLWFPBlX/fpXikBDZ1gvOr8nyMY9nXhgfXpq3B6QCRYKPy58ChrZ5weeJZ29b7/ QdEO8NFNWHjSD9meiLdWQaqo9Y7uUxN3wySc/YUZxtS0bhAd8zJdNPsJYG8sXgKjeBQMVGuT eCAJFEYJqbwWvIXMfVWop4+O4xB+z2YE3jAbG/9tB/GSnQdVSj3G8MS80iLS58frnt+RSEw/ psahrfh0dh6SFHttE049xYiC+cM8J27Aaf0i9RflyITq57NuJm+AHJoU9SQUkIF0nc6lfA+o JRiyRlHZHKoRQkIg4aiKaZSWjQYRl5Txl0IZUP1dSWMX4s3XTMurC/pnja45dge/4ESOtJ9R 8XuIWg45Oq6MeIWdjKddGhRj3OohsltKgkEU3eLKYtB6qRTQypHHUawCXz88uYt5e3w4V16H lCpSTZV/EVHnNe45FVBlvK7k7HFfDDkryLkCDQRZuCyIARAAlq0slcsVboY/+IUJdcbEiJRW be9HKVz4SUchq0z9MZPX/0dcnvz/gkyYA+OuM78dNS7Mbby5dTvOqfpLJfCuhaNYOhlE0wY+ 1T6Tf1f4c/uA3U/YiadukQ3+6TJuYGAdRZD5EqYFIkreARTVWg87N9g0fT9BEqLw9lJtEGDY EWUE7L++B8o4uu3LQFEYxcrb4K/WKmgtmFcm77s0IKDrfcX4doV92QTIpLiRxcOmCC/OCYuO jB1oaaqXQzZrCutXRK0L5XN1Y1PYjIrEzHMIXmCDlLYnpFkK+itlXwlE2ZQxkfMruCWdQXye syl2fynAe8hvp7Mms9qU2r2K9EcJiR5N1t1C2/kTKNUhcRv7Yd/vwusK7BqJbhlng5ZgRx0m WxdntU/JLEntz3QBsBsWM9Y9wf2V4tLv6/DuDBta781RsCB/UrU2zNuOEkSixlUiHxw1dccI 6CVlaWkkJBxmHX22GdDFrcjvwMNIbbyfQLuBq6IOh8nvu9vuItup7qemDG3Ms6TVwA7BD3j+ 3fGprtyW8Fd/RR2bW2+LWkMrqHffAr6Y6V3h5kd2G9Q8ZWpEJk+LG6Mk3fhZhmCnHhDu6CwN MeUvxXDVO+fqc3JjFm5OxhmfVeJKrbCEUJyM8ESWLoNHLqjywdZga4Q7P12g8DUQ1mRxYg/L HgZY3zfKOqcAEQEAAYkCPAQYAQgAJhYhBL4sQ7ueBCdcDgGOvnfybtNRzXKPBQJZuCyIAhsM BQkFo5qAAAoJEHfybtNRzXKPBVwQAKfFy9P7N3OsLDMB56A4Kf+ZT+d5cIx0Yiaf4n6w7m3i ImHHHk9FIetI4Xe54a2IXh4Bq5UkAGY0667eIs+Z1Ea6I2i27Sdo7DxGwq09Qnm/Y65ADvXs 3aBvokCcm7FsM1wky395m8xUos1681oV5oxgqeRI8/76qy0hD9WR65UW+HQgZRIcIjSel9vR XDaD2HLGPTTGr7u4v00UeTMs6qvPsa2PJagogrKY8RXdFtXvweQFz78NbXhluwix2Tb9ETPk LIpDrtzV73CaE2aqBG/KrboXT2C67BgFtnk7T7Y7iKq4/XvEdDWscz2wws91BOXuMMd4c/c4 OmGW9m3RBLufFrOag1q5yUS9QbFfyqL6dftJP3Zq/xe+mr7sbWbhPVCQFrH3r26mpmy841ym dwQnNcsbIGiBASBSKksOvIDYKa2Wy8htPmWFTEOPRpFXdGQ27awcjjnB42nngyCK5ukZDHi6 w0qK5DNQQCkiweevCIC6wc3p67jl1EMFY5+z+zdTPb3h7LeVnGqW0qBQl99vVFgzLxchKcl0 R/paSFgwqXCZhAKMuUHncJuynDOP7z5LirUeFI8qsBAJi1rXpQoLJTVcW72swZ42IdPiboqx NbTMiNOiE36GqMcTPfKylCbF45JNX4nF9ElM0E+Y8gi4cizJYBRr2FBJgay0b9Cp Message-ID: <258a6528-2d43-d72e-b5e1-b189566a9b50@FreeBSD.org> Date: Sun, 10 May 2020 00:02:19 +0300 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101 Firefox/60.0 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20200509204743.GA68906@kib.kiev.ua> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 49KKQT26lgz4Kv4 X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of agapon@gmail.com designates 209.85.208.175 as permitted sender) smtp.mailfrom=agapon@gmail.com X-Spamd-Result: default: False [-1.24 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; RCVD_COUNT_THREE(0.00)[3]; TO_DN_ALL(0.00)[]; SUBJECT_HAS_EXCLAIM(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; FORGED_SENDER(0.30)[avg@FreeBSD.org,agapon@gmail.com]; FREEMAIL_TO(0.00)[gmail.com]; RECEIVED_SPAMHAUS_PBL(0.00)[96.151.72.93.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.10]; SUBJECT_ENDS_QUESTION(1.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; R_DKIM_NA(0.00)[]; FROM_NEQ_ENVFROM(0.00)[avg@FreeBSD.org,agapon@gmail.com]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.99)[-0.988,0]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-0.999,0]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; DMARC_NA(0.00)[FreeBSD.org]; MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[175.208.85.209.list.dnswl.org : 127.0.5.0]; IP_SCORE(-0.25)[ip: (-0.38), ipnet: 209.85.128.0/17(-0.39), asn: 15169(-0.43), country: US(-0.05)]; RWL_MAILSPIKE_POSSIBLE(0.00)[175.208.85.209.rep.mailspike.net : 127.0.0.17]; RCVD_TLS_ALL(0.00)[] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.32 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 09 May 2020 21:02:26 -0000 On 09/05/2020 23:47, Konstantin Belousov wrote: > Might be not, might be it would help due to pmap_delayed_invl_genp(). > But I would more worry about this 'already started' issue, because > this must not happen. Can you remove the assert from the macro and > provide backtrace of 'DI already started' panic ? Oh, now that you asked for it, I see that it was a secondary panic (through vt, fb, drm code path). The first panic was still the same "address %lx beyond the last segment". I'll test your suggestion tomorrow. #10 0xffffffff8080340e in vpanic (fmt=, ap=) at /usr/devel/git/motil/sys/kern/kern_shutdown.c:902 #11 0xffffffff808031a3 in panic (fmt=0xffffffff8119a998 "\265\001ʀ\377\377\377\377") at /usr/devel/git/motil/sys/kern/kern_shutdown.c:839 #12 0xffffffff80bb4c05 in pmap_delayed_invl_start_u () at /usr/devel/git/motil/sys/amd64/amd64/pmap.c:783 #13 0xffffffff80bb8ede in pmap_remove (pmap=0xffffffff812ee930 , sva=18446741877558251520, eva=) at /usr/devel/git/motil/sys/amd64/amd64/pmap.c:5418 #14 0xffffffff80b2b6ad in _kmem_unback (object=, addr=18446741877558251520, size=102400) at /usr/devel/git/motil/sys/vm/vm_kern.c:574 #15 0xffffffff80b2b7dd in kmem_free (addr=18446741877558251520, size=102400) at /usr/devel/git/motil/sys/vm/vm_kern.c:614 #16 0xffffffff807db77b in free_large (addr=0xfffffe00ab2e9000, size=102400) at /usr/devel/git/motil/sys/kern/kern_malloc.c:599 #17 free (addr=0xfffffe00ab2e9000, mtp=0xffffffff825f90c0 ) at /usr/devel/git/motil/sys/kern/kern_malloc.c:818 #18 0xffffffff82444922 in dc_gamma_release (gamma=) at /usr/home/avg/devel/kms-drm/drivers/gpu/drm/amd/display/dc/core/dc_surface.c:162 #19 destruct (plane_state=0xfffff800080ef800) at /usr/home/avg/devel/kms-drm/drivers/gpu/drm/amd/display/dc/core/dc_surface.c:53 #20 dc_plane_state_free (kref=) at /usr/home/avg/devel/kms-drm/drivers/gpu/drm/amd/display/dc/core/dc_surface.c:140 #21 kref_put (kref=, rel=) at /usr/devel/git/motil/sys/compat/linuxkpi/common/include/linux/kref.h:74 #22 dc_plane_state_release (plane_state=) at /usr/home/avg/devel/kms-drm/drivers/gpu/drm/amd/display/dc/core/dc_surface.c:146 #23 0xffffffff82442de9 in dc_resource_state_destruct (context=0xfffffe00a2af0000) at /usr/home/avg/devel/kms-drm/drivers/gpu/drm/amd/display/dc/core/dc_resource.c:2295 #24 0xffffffff824355d2 in dc_state_free (kref=) at /usr/home/avg/devel/kms-drm/drivers/gpu/drm/amd/display/dc/core/dc.c:1152 #25 kref_put (kref=, rel=) at /usr/devel/git/motil/sys/compat/linuxkpi/common/include/linux/kref.h:74 #26 dc_release_state (context=) at /usr/home/avg/devel/kms-drm/drivers/gpu/drm/amd/display/dc/core/dc.c:1158 #27 0xffffffff8241f6cc in dm_atomic_destroy_state (obj=, state=0xfffff80020465550) at /usr/home/avg/devel/kms-drm/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:1667 #28 0xffffffff82569734 in drm_atomic_state_default_clear (state=0xfffff80008274a00) at /usr/home/avg/devel/kms-drm/drivers/gpu/drm/drm_atomic.c:202 #29 0xffffffff82569827 in drm_atomic_state_clear (state=) at /usr/home/avg/devel/kms-drm/drivers/gpu/drm/drm_atomic.c:240 #30 __drm_atomic_state_free (ref=0xfffff80008274a00) at /usr/home/avg/devel/kms-drm/drivers/gpu/drm/drm_atomic.c:256 #31 0xffffffff825998d8 in kref_put (kref=0xfffff80008274a00, rel=) at /usr/devel/git/motil/sys/compat/linuxkpi/common/include/linux/kref.h:74 #32 drm_atomic_state_put (state=0xfffff80008274a00) at /usr/home/avg/devel/kms-drm/include/drm/drm_atomic.h:385 #33 restore_fbdev_mode_atomic (fb_helper=, active=true) at /usr/home/avg/devel/kms-drm/drivers/gpu/drm/drm_fb_helper.c:461 #34 0xffffffff8259567a in drm_fb_helper_restore_fbdev_mode_unlocked (fb_helper=0xfffff8002096d800) at /usr/home/avg/devel/kms-drm/drivers/gpu/drm/drm_fb_helper.c:549 #35 0xffffffff825bcc8a in vt_kms_postswitch (arg=0xfffff800027c52c0) at /usr/home/avg/devel/kms-drm/drivers/gpu/drm/linux_fb.c:97 #36 0xffffffff806b04b2 in vt_window_switch (vw=0xffffffff80e999a8 ) at /usr/devel/git/motil/sys/dev/vt/vt_core.c:603 #37 0xffffffff806ada0f in vtterm_cngrab (tm=) at /usr/devel/git/motil/sys/dev/vt/vt_core.c:1612 #38 0xffffffff8079f776 in cngrab () at /usr/devel/git/motil/sys/kern/kern_cons.c:397 #39 0xffffffff8080335c in vpanic (fmt=0xffffffff80cc257f "address %lx beyond the last segment", ap=0xfffffe009e18c890) at /usr/devel/git/motil/sys/kern/kern_shutdown.c:887 #40 0xffffffff808031a3 in panic (fmt=0xffffffff8119a998 "\265\001ʀ\377\377\377\377") at /usr/devel/git/motil/sys/kern/kern_shutdown.c:839 #41 0xffffffff80bc2ac3 in pmap_remove_pte (pmap=0xfffffe00a4cdbb08, ptq=0xfffff800cd2b4000, va=34523316224, ptepde=3442163815, free=0xfffffe009e18c9a0, lockp=0xfffffe009e18c9b8) at /usr/devel/git/motil/sys/amd64/amd64/pmap.c:3599 #42 0xffffffff80bba98c in pmap_remove_ptes (pmap=0xfffffe00a4cdbb08, sva=34523316224, eva=34525413376, pde=0xfffff800b2515270, free=0xfffffe009e18c9a0, lockp=0xfffffe009e18c9b8) at /usr/devel/git/motil/sys/amd64/amd64/pmap.c:5378 #43 0xffffffff80bb921c in pmap_remove (pmap=, sva=34523316224, eva=) at /usr/devel/git/motil/sys/amd64/amd64/pmap.c:5506 #44 0xffffffff80b301a0 in vm_map_delete (map=0xfffffe00a4cdb9e8, start=, end=) at /usr/devel/git/motil/sys/vm/vm_map.c:3804 #45 0xffffffff80b3856e in kern_munmap (td=0xfffffe009c7be800, addr0=, size=2097152) at /usr/devel/git/motil/sys/vm/vm_mmap.c:624 #46 0xffffffff80bcff00 in syscallenter (td=) at /usr/devel/git/motil/sys/amd64/amd64/../../kern/subr_syscall.c:162 #47 amd64_syscall (td=0xfffffe009c7be800, traced=0) at /usr/devel/git/motil/sys/amd64/amd64/trap.c:1161 -- Andriy Gapon