From owner-svn-src-all@FreeBSD.ORG Wed Dec 14 01:03:07 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BE35F106564A; Wed, 14 Dec 2011 01:03:07 +0000 (UTC) (envelope-from hselasky@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id AD0298FC12; Wed, 14 Dec 2011 01:03:07 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.4/8.14.4) with ESMTP id pBE137MI075162; Wed, 14 Dec 2011 01:03:07 GMT (envelope-from hselasky@svn.freebsd.org) Received: (from hselasky@localhost) by svn.freebsd.org (8.14.4/8.14.4/Submit) id pBE137go075160; Wed, 14 Dec 2011 01:03:07 GMT (envelope-from hselasky@svn.freebsd.org) Message-Id: <201112140103.pBE137go075160@svn.freebsd.org> From: Hans Petter Selasky Date: Wed, 14 Dec 2011 01:03:07 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r228485 - head/sys/dev/sound/usb X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Dec 2011 01:03:07 -0000 Author: hselasky Date: Wed Dec 14 01:03:07 2011 New Revision: 228485 URL: http://svn.freebsd.org/changeset/base/228485 Log: Use usbd_transfer_unsetup() instead of usbd_transfer_stop() so that we don't have to worry about locking. MFC after: 1 weeks Modified: head/sys/dev/sound/usb/uaudio.c Modified: head/sys/dev/sound/usb/uaudio.c ============================================================================== --- head/sys/dev/sound/usb/uaudio.c Wed Dec 14 00:48:20 2011 (r228484) +++ head/sys/dev/sound/usb/uaudio.c Wed Dec 14 01:03:07 2011 (r228485) @@ -770,8 +770,10 @@ uaudio_detach(device_t dev) * will time out and close opened /dev/dspX.Y device(s), if * any. */ - uaudio_chan_stop(&sc->sc_play_chan); - uaudio_chan_stop(&sc->sc_rec_chan); + if (sc->sc_play_chan.valid) + usbd_transfer_unsetup(sc->sc_play_chan.xfer, UAUDIO_NCHANBUFS); + if (sc->sc_rec_chan.valid) + usbd_transfer_unsetup(sc->sc_rec_chan.xfer, UAUDIO_NCHANBUFS); if (bus_generic_detach(dev) != 0) { DPRINTF("detach failed!\n");