From owner-cvs-all Tue Feb 27 2:20:55 2001 Delivered-To: cvs-all@freebsd.org Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id EEAF037B718; Tue, 27 Feb 2001 02:20:49 -0800 (PST) (envelope-from billf@FreeBSD.org) Received: (from billf@localhost) by freefall.freebsd.org (8.11.1/8.11.1) id f1RAKne38567; Tue, 27 Feb 2001 02:20:49 -0800 (PST) (envelope-from billf) Message-Id: <200102271020.f1RAKne38567@freefall.freebsd.org> From: Bill Fumerola Date: Tue, 27 Feb 2001 02:20:47 -0800 (PST) To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/netinet ip_fw.c X-FreeBSD-CVS-Branch: HEAD Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG billf 2001/02/27 02:20:47 PST Modified files: sys/netinet ip_fw.c Log: The TCP header-specific section suffered a little bit of bitrot recently: When we recieve a fragmented TCP packet (other than the first) we can't extract header information (we don't have state to reference). In a rather unelegant fashion we just move on and assume a non-match. Recent additions to the TCP header-specific section of the code neglected to add the logic to the fragment code so in those cases the match was assumed to be positive and those parts of the rule (which should have resulted in a non-match/continue) were instead skipped (which means the processing of the rule continued even though it had already not matched). Fault can be spread out over Rich Steenbergen (tcpoptions) and myself (tcp{seq,ack,win}). rwatson sent me a patch that got me thinking about this whole situation (but what I'm committing / this description is mine so don't blame him). Revision Changes Path 1.160 +2 -2 src/sys/netinet/ip_fw.c To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message