From owner-freebsd-bugs  Thu Sep  6 10:50:13 2001
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id 721D737B407
	for <freebsd-bugs@hub.freebsd.org>; Thu,  6 Sep 2001 10:50:01 -0700 (PDT)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.11.4/8.11.4) id f86Ho1c39911;
	Thu, 6 Sep 2001 10:50:01 -0700 (PDT)
	(envelope-from gnats)
Received: from Clarke.i-pi.com (Clarke.i-pi.com [198.49.217.12])
	by hub.freebsd.org (Postfix) with ESMTP id 2F3CD37B405
	for <FreeBSD-gnats-submit@freebsd.org>; Thu,  6 Sep 2001 10:46:10 -0700 (PDT)
Received: (from root@localhost)
	by Clarke.i-pi.com (8.11.6/8.11.1) id f86Hk0c35300;
	Thu, 6 Sep 2001 11:46:00 -0600 (MDT)
	(envelope-from ingham)
Message-Id: <200109061746.f86Hk0c35300@Clarke.i-pi.com>
Date: Thu, 6 Sep 2001 11:46:00 -0600 (MDT)
From: Kenneth Ingham <ingham@i-pi.com>
Reply-To: Kenneth Ingham <ingham@i-pi.com>
To: FreeBSD-gnats-submit@freebsd.org
X-Send-Pr-Version: 3.113
Subject: bin/30404: sshd debug messaves need clarification
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-bugs.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-bugs>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-bugs>
X-Loop: FreeBSD.org


>Number:         30404
>Category:       bin
>Synopsis:       sshd debug messaves need clarification
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Thu Sep 06 10:50:01 PDT 2001
>Closed-Date:
>Last-Modified:
>Originator:     Kenneth Ingham
>Release:        FreeBSD 4.4-RC i386
>Organization:
>Environment:
System: FreeBSD Clarke.i-pi.com 4.4-RC FreeBSD 4.4-RC #15: Thu Aug 30 11:08:58 MDT 2001 ingham@Clarke.i-pi.com:/usr/src/sys/compile/CLARKE i386


>Description:
	ssh -d has two identical ``callback done'' messages.
>How-To-Repeat:
	look at channels.c in sshd source
>Fix:
Apply the following patch

*** channels.c	Thu Sep  6 11:39:43 2001
--- channels.c.orig	Thu Sep  6 11:39:24 2001
***************
*** 1250,1258 ****
  		c->remote_maxpacket = packet_get_int();
  		packet_done();
  		if (c->cb_fn != NULL && c->cb_event == type) {
! 			debug2("channel confirmation callback start");
  			c->cb_fn(c->self, c->cb_arg);
! 			debug2("channel confirmation callback done");
  		}
  		debug("channel %d: open confirm rwindow %d rmax %d", c->self,
  		    c->remote_window, c->remote_maxpacket);
--- 1250,1258 ----
  		c->remote_maxpacket = packet_get_int();
  		packet_done();
  		if (c->cb_fn != NULL && c->cb_event == type) {
! 			debug2("callback start");
  			c->cb_fn(c->self, c->cb_arg);
! 			debug2("callback done");
  		}
  		debug("channel %d: open confirm rwindow %d rmax %d", c->self,
  		    c->remote_window, c->remote_maxpacket);
***************
*** 1301,1309 ****
  		packet_disconnect("Received request for "
  		    "non-open channel %d.", id);
  	if (c->cb_fn != NULL && c->cb_event == type) {
! 		debug2("channel request callback start");
  		c->cb_fn(c->self, c->cb_arg);
! 		debug2("channel request callback done");
  	} else {
  		char *service = packet_get_string(NULL);
  		debug("channel: %d rcvd request for %s", c->self, service);
--- 1301,1309 ----
  		packet_disconnect("Received request for "
  		    "non-open channel %d.", id);
  	if (c->cb_fn != NULL && c->cb_event == type) {
! 		debug2("callback start");
  		c->cb_fn(c->self, c->cb_arg);
! 		debug2("callback done");
  	} else {
  		char *service = packet_get_string(NULL);
  		debug("channel: %d rcvd request for %s", c->self, service);
>Release-Note:
>Audit-Trail:
>Unformatted:

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message