From owner-svn-src-head@freebsd.org  Wed Sep  2 18:35:36 2015
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id C960C9C89CE;
 Wed,  2 Sep 2015 18:35:36 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id A7E6C68A;
 Wed,  2 Sep 2015 18:35:36 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net
 [73.231.226.104])
 by bigwig.baldwin.cx (Postfix) with ESMTPSA id A9D47B9A9;
 Wed,  2 Sep 2015 14:35:35 -0400 (EDT)
From: John Baldwin <jhb@freebsd.org>
To: "Conrad E. Meyer" <cem@freebsd.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r287403 - head/sys/dev/ioat
Date: Wed, 02 Sep 2015 10:26:43 -0700
Message-ID: <3589074.YABE6tqvK0@ralph.baldwin.cx>
User-Agent: KMail/4.14.3 (FreeBSD/10.2-PRERELEASE; KDE/4.14.3; amd64; ; )
In-Reply-To: <201509021648.t82Gm451015184@repo.freebsd.org>
References: <201509021648.t82Gm451015184@repo.freebsd.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7
 (bigwig.baldwin.cx); Wed, 02 Sep 2015 14:35:35 -0400 (EDT)
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 02 Sep 2015 18:35:36 -0000

On Wednesday, September 02, 2015 04:48:04 PM Conrad E. Meyer wrote:
> Author: cem
> Date: Wed Sep  2 16:48:03 2015
> New Revision: 287403
> URL: https://svnweb.freebsd.org/changeset/base/287403
> 
> Log:
>   ioat: re-initialize interrupts after resetting hw on BDXDE
>   
>   Resetting some generations of the I/OAT hardware (just BDXDE for now)
>   resets the corresponding MSI-X registers.  So, teardown and
>   re-initialize interrupts after resetting the hardware.
>   
>   Reviewed by:	jimharris
>   Approved by:	markj (mentor)
>   Sponsored by:	EMC / Isilon Storage Division
>   Differential Revision:	https://reviews.freebsd.org/D3549

Alternatively you could use pci_restore_state() (before reset) and
pci_save_state() (after reset) to restore standard PCI config registers
(including MSI/MSI-X) after a reset.

This might be more scalable if you want to ensure other PCI config
registers (e.g. PCI-e capabilities) are restored after a reset.

-- 
John Baldwin