From owner-freebsd-arch@freebsd.org  Thu May 12 02:33:35 2016
Return-Path: <owner-freebsd-arch@freebsd.org>
Delivered-To: freebsd-arch@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9A400B363C8
 for <freebsd-arch@mailman.ysv.freebsd.org>;
 Thu, 12 May 2016 02:33:35 +0000 (UTC)
 (envelope-from alfred@freebsd.org)
Received: from elvis.mu.org (elvis.mu.org [192.203.228.196])
 by mx1.freebsd.org (Postfix) with ESMTP id 8B16F1DE7;
 Thu, 12 May 2016 02:33:35 +0000 (UTC)
 (envelope-from alfred@freebsd.org)
Received: from Alfreds-MacBook-Pro-2.local (unknown
 [IPv6:2601:645:8003:a4d6:5813:8fd5:ad51:daf5])
 by elvis.mu.org (Postfix) with ESMTPSA id 84C87346DE31;
 Wed, 11 May 2016 19:33:34 -0700 (PDT)
Subject: Re: KASSERT: always assert; KWARN
To: Rui Paulo <rpaulo@me.com>, John Baldwin <jhb@freebsd.org>,
 freebsd-arch@freebsd.org, cem@freebsd.org
References: <CAG6CVpWzuK6cZx3QnQhKOu=6GZBJF4cJQdNXgJZeXYhuJJANJg@mail.gmail.com>
 <ca489ff1-f520-3feb-0525-425eb015af7a@freebsd.org>
 <CAG6CVpWNzmaqKsOKJtuG1642m0knkupAoK=BoGq5iNHC1TA-Gw@mail.gmail.com>
 <31200026.OetD7h0dHc@ralph.baldwin.cx> <1463010600.7806.10.camel@me.com>
From: Alfred Perlstein <alfred@freebsd.org>
Organization: FreeBSD
Message-ID: <fe73ace8-b59c-c43a-3311-dd99de9b3f2b@freebsd.org>
Date: Wed, 11 May 2016 19:34:17 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0)
 Gecko/20100101 Thunderbird/45.0
MIME-Version: 1.0
In-Reply-To: <1463010600.7806.10.camel@me.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Discussion related to FreeBSD architecture <freebsd-arch.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-arch>,
 <mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch/>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
 <mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 12 May 2016 02:33:35 -0000



On 5/11/16 4:50 PM, Rui Paulo wrote:
> On Wed, 2016-05-11 at 09:48 -0700, John Baldwin wrote:
>> Eh, if you keep going past many of the assertions the original code
>> enabled, you will get _more_ bogus assertions as fallout.
> I agree with John.  We really shouldn't be fiddling with this.
>
> There's just one case where this could be useful: you just imported a
> bunch of code that you don't understand and you're using the kassert's
> as a way to create a mental model of the code.  However, this is a very
> specific edge case.
>
I'm not sure what you and John are suggesting here.

Are you suggesting to revert the explicit panics in the witness code, or 
to revert the entire kassert_warn subsystem?

-Alfred