From owner-freebsd-hackers@FreeBSD.ORG Mon Aug 9 20:00:06 2004 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 20C7216A4D0 for ; Mon, 9 Aug 2004 20:00:06 +0000 (GMT) Received: from koala.domainit.com (koala.domainit.com [206.21.217.15]) by mx1.FreeBSD.org (Postfix) with SMTP id C4B4D43D2D for ; Mon, 9 Aug 2004 20:00:05 +0000 (GMT) (envelope-from cokane@cokane.org) Received: (qmail 52243 invoked by uid 85); 9 Aug 2004 20:03:00 -0000 X-Remote-IP: 216.196.247.106 Received: from ddsl-216-196-247-106.fuse.net (HELO ?192.168.2.251?) (216.196.247.106) by mail.domainit.com with SMTP; 9 Aug 2004 20:03:00 -0000 From: Coleman To: Yar Tikhiy In-Reply-To: <20040807092347.GB39835@comp.chem.msu.su> References: <346a8022040806145018a5e18@mail.gmail.com> <1091862376.7840.3.camel@berloga.shadowland> <20040807092347.GB39835@comp.chem.msu.su> Content-Type: text/plain Message-Id: <1092081623.65806.3.camel@schemer> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.6 Date: Mon, 09 Aug 2004 16:00:24 -0400 Content-Transfer-Encoding: 7bit X-Mailman-Approved-At: Tue, 10 Aug 2004 11:40:49 +0000 cc: hackers@freebsd.org cc: Alex Lyashkov Subject: Re: Network interface RUNNING and UP flags X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Aug 2004 20:00:06 -0000 Seems to work in both -RELEASE and -CURRENT, though I needed to manually apply the patch as line numbers were off in -RELEASE. I can see how the locking could become a problem in -CURRENT. On Sat, 2004-08-07 at 05:23, Yar Tikhiy wrote: > On Sat, Aug 07, 2004 at 10:06:17AM +0300, Alex Lyashkov wrote: > > > > not better move this under tp->tap_mtx mutex without using splX > > functions? > > ...especially taking into account that splX do nothing > in CURRENT anyway. Mutex locking framework adopted by > the interface driver should be used of course.