From owner-freebsd-toolchain@freebsd.org  Sun Jul 16 06:08:16 2017
Return-Path: <owner-freebsd-toolchain@freebsd.org>
Delivered-To: freebsd-toolchain@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id CEE77BF73C7
 for <freebsd-toolchain@mailman.ysv.freebsd.org>;
 Sun, 16 Jul 2017 06:08:16 +0000 (UTC)
 (envelope-from gerald@pfeifer.com)
Received: from ainaz.pair.com (ainaz.pair.com [209.68.2.66])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 45E416E80F;
 Sun, 16 Jul 2017 06:08:15 +0000 (UTC)
 (envelope-from gerald@pfeifer.com)
Received: from ainaz.pair.com (localhost [127.0.0.1])
 by ainaz.pair.com (Postfix) with ESMTP id 4D8153F66C;
 Sun, 16 Jul 2017 02:08:07 -0400 (EDT)
Received: from anthias (vie-188-118-244-226.dsl.sil.at [188.118.244.226])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ainaz.pair.com (Postfix) with ESMTPSA id 14FBD3F66B;
 Sun, 16 Jul 2017 02:08:05 -0400 (EDT)
Date: Sun, 16 Jul 2017 08:08:04 +0200 (CEST)
From: Gerald Pfeifer <gerald@pfeifer.com>
To: Dimitry Andric <dim@FreeBSD.org>, Jung-uk Kim <jkim@FreeBSD.org>
cc: Andreas Tobler <andreast@FreeBSD.org>, freebsd-toolchain@freebsd.org
Subject: Re: Duplicate OPT_ entries in gcc/options.h
In-Reply-To: <0610816e-2675-1abf-a4ee-274807317932@FreeBSD.org>
Message-ID: <alpine.LSU.2.21.1707160805430.5621@anthias.pfeifer.com>
References: <alpine.LSU.2.20.1606082038000.2798@anthias.pfeifer.com>
 <75411813-0C9B-4CEF-BEE4-8B26DD8346F7@FreeBSD.org>
 <0610816e-2675-1abf-a4ee-274807317932@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
X-BeenThere: freebsd-toolchain@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: Maintenance of FreeBSD's integrated toolchain
 <freebsd-toolchain.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-toolchain>, 
 <mailto:freebsd-toolchain-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-toolchain/>
List-Post: <mailto:freebsd-toolchain@freebsd.org>
List-Help: <mailto:freebsd-toolchain-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-toolchain>, 
 <mailto:freebsd-toolchain-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 16 Jul 2017 06:08:16 -0000

On Wed, 8 Jun 2016, Dimitry Andric wrote:
>> I got a user report, and could reproduce this, that building
>> GCC (lang/gcc, but also current HEAD, so probably pretty much
>> any version) with FreeBSD 11 and LANG = en_US.UTF-8 we get
>> conflicting entires in $BUILDDIR/gcc/options.h such as
>> 
>>  OPT_d = 135,                               /* -d */
>>  OPT_D = 136,                               /* -D */
>>  OPT_d = 137,                               /* -d */
>>  OPT_D = 138,                               /* -D */
>>  OPT_d = 141,                               /* -d */
>>  OPT_D = 142,                               /* -D */
>>  OPT_d = 143,                               /* -d */
>> 
>> Using LANG = en_US (without UTF-8), everything works fine.
> It is definitely something caused by our awk in base, in any case.

Thanks for the fine debugging, Dimitry...

And Jung-uk Kim wrote:
> This behaviour is known for very long time:
>
> https://svnweb.freebsd.org/changeset/base/173731
> 
> and it is not our fault:
>
> https://www.gnu.org/software/gawk/manual/html_node/POSIX-String-Comparison.html

...and for this background, Jung-uk!

To close this thread, this is now properly addressed upstream by
always forcing C locale when running this AWK script (after we did
some temporary hack to the same effect in our ports).

Gerald