Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 1 Feb 2018 21:04:11 +0000 (UTC)
From:      Alexander Motin <mav@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org
Subject:   svn commit: r328732 - stable/11/sbin/nvmecontrol
Message-ID:  <201802012104.w11L4BFY072791@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: mav
Date: Thu Feb  1 21:04:10 2018
New Revision: 328732
URL: https://svnweb.freebsd.org/changeset/base/328732

Log:
  MFC r320522 (by imp):
  Fix sign of resid and add a mostly useless cast to cope with signed vs
  unsigned check warnings from traditional unix code construsts bogusly
  flagged as potentially unsafe.

Modified:
  stable/11/sbin/nvmecontrol/wdc.c
Directory Properties:
  stable/11/   (props changed)

Modified: stable/11/sbin/nvmecontrol/wdc.c
==============================================================================
--- stable/11/sbin/nvmecontrol/wdc.c	Thu Feb  1 19:57:21 2018	(r328731)
+++ stable/11/sbin/nvmecontrol/wdc.c	Thu Feb  1 21:04:10 2018	(r328732)
@@ -105,7 +105,7 @@ wdc_do_dump(int fd, char *tmpl, const char *suffix, ui
 	int fd2;
 	uint8_t *buf;
 	uint32_t len, offset;
-	ssize_t resid;
+	size_t resid;
 
 	wdc_append_serial_name(fd, tmpl, MAXPATHLEN, suffix);
 
@@ -142,7 +142,7 @@ wdc_do_dump(int fd, char *tmpl, const char *suffix, ui
 				resid = len;
 			first = 0;
 		}
-		if (write(fd2, buf, resid) != resid)
+		if (write(fd2, buf, resid) != (ssize_t)resid)
 			err(1, "write");
 		offset += resid;
 		len -= resid;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201802012104.w11L4BFY072791>