From owner-svn-src-all@freebsd.org Tue Sep 1 16:28:17 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 585F63CE36F; Tue, 1 Sep 2020 16:28:17 +0000 (UTC) (envelope-from andrew@fubar.geek.nz) Received: from fry.fubar.geek.nz (fry.fubar.geek.nz [139.59.165.16]) by mx1.freebsd.org (Postfix) with ESMTP id 4Bgsv509Lqz3YY5; Tue, 1 Sep 2020 16:28:16 +0000 (UTC) (envelope-from andrew@fubar.geek.nz) Received: from [192.168.42.12] (cpc91220-cmbg18-2-0-cust60.5-4.cable.virginm.net [81.104.142.61]) by fry.fubar.geek.nz (Postfix) with ESMTPSA id 9FFEE4E720; Tue, 1 Sep 2020 16:27:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fubar.geek.nz; s=mail; t=1598977658; bh=sKJ2dBljsQOigNpnavMZBlz/6O0BpG1mdNbPkOQoObE=; h=Subject:From:In-Reply-To:Date:Cc:References:To; b=qmgpnMTjwlnMaF/E3sc7h3O+7rwJoQFdP+1SgCHxU/vwG1XsuPKg3lgrUY9WnNshX 67xLKN7MqQgxgtMDDUTAtQ1sa3CxDNAI6EK8x5eqM5IBN90pAo7Z7jWyf7qyCQdiVi zMFm2ljKy/tunhQbaMdodGzg4j0OPH7qB5Ek+rM9WqXIecjuMprHbGLuQkVUi3XZa5 pv4Ly6VdN3p7kzHNSh9wh9Q9mFtu44q0BYaTiAuOSxYXNJ1hyTo/M5i3Yd1pbZLkXU BvKgGyJHI8vqDq/UvM1MVhxvazGUa05TRZaujZ8hovzn9+3aAm6OwI8juKDR2PQpQX w1ZJN2nuIJWUtZc+DehUlCDi7tiHhzOtCGHgKxlRL4quSMLM1NeTDD5+tUSJRUD/qj 9Y+y7qVzpbX8F/KJSt2Q64DMPLmWwmp7UAfF0RupPfTchYM1lu/iQG3Cw4q5OU/XTn 5Hnidz6d5yP6Rs0qZUosZgBrQ3LasYXhHgzrs9OMUi441PCGHTL7/g0s/gylVASDo9 TeRZkkMAcHd9WGvvJ7GCizma41EqnOj66A+x97N+LZh2O2DFpJSj0/OJfNcMicoXJl kxU4p0zg//rOsZT0+uCIoeusPi0k2qbp/2KRTCY1chAX5JRVVdJUZaqvbUXUVAJ31i 4X7+V4X1jZKjJPyIImxUUfZc= Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.15\)) Subject: Re: svn commit: r365054 - in head/sys: conf dev/sdhci From: Andrew Turner In-Reply-To: <202009011617.081GHL8e031671@repo.freebsd.org> Date: Tue, 1 Sep 2020 17:27:35 +0100 Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <874D5323-F0DB-44E9-8779-7C18832A98B4@fubar.geek.nz> References: <202009011617.081GHL8e031671@repo.freebsd.org> To: Marcin Wojtas X-Mailer: Apple Mail (2.3445.104.15) X-Rspamd-Queue-Id: 4Bgsv509Lqz3YY5 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:14061, ipnet:139.59.160.0/20, country:US] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Sep 2020 16:28:17 -0000 > On 1 Sep 2020, at 17:17, Marcin Wojtas wrote: >=20 > Author: mw > Date: Tue Sep 1 16:17:21 2020 > New Revision: 365054 > URL: https://svnweb.freebsd.org/changeset/base/365054 >=20 > Log: > Introduce the SDHCI driver for NXP QorIQ Layerscape SoCs >=20 > Implement support for an eSDHC controller found in NXP QorIQ = Layerscape SoCs. >=20 > This driver has been tested with NXP LS1046A and LX2160A (Honeycomb = board), > which is incompatible with the existing sdhci_fsl driver (aiming at = older > chips from this family). As such, it is not intended as replacement = for > the old driver, but rather serves as an improved alternative for SoCs = that > support it. > It comes with support for both PIO and Single DMA modes and samples = the > clock from the extres clk API. >=20 > Submitted by: Artur Rojek > Reviewed by: manu, mmel, kibab > Obtained from: Semihalf > Sponsored by: Alstom Group > Differential Revision: https://reviews.freebsd.org/D26153 >=20 > Added: > head/sys/dev/sdhci/sdhci_fsl_fdt.c (contents, props changed) > Modified: > head/sys/conf/files >=20 > Modified: head/sys/conf/files > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > --- head/sys/conf/files Tue Sep 1 16:13:09 2020 = (r365053) > +++ head/sys/conf/files Tue Sep 1 16:17:21 2020 = (r365054) > @@ -3058,6 +3058,7 @@ dev/scc/scc_dev_z8530.c optional scc > dev/sdhci/sdhci.c optional sdhci > dev/sdhci/sdhci_fdt.c optional sdhci fdt > dev/sdhci/sdhci_fdt_gpio.c optional sdhci fdt gpio > +dev/sdhci/sdhci_fsl_fdt.c optional sdhci fdt gpio This looks wrong. It should be using an NXP specific option, not gpio. Andrew=