Date: Mon, 31 Aug 2015 12:48:47 +0200 From: John Marino <freebsd.contact@marino.st> To: Raphael Kubo da Costa <rakuco@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r395661 - head/graphics/graphite2 Message-ID: <55E4310F.8090809@marino.st> In-Reply-To: <201508311018.t7VAIp8v001403@repo.freebsd.org> References: <201508311018.t7VAIp8v001403@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 8/31/2015 12:18 PM, Raphael Kubo da Costa wrote: > Author: rakuco > Date: Mon Aug 31 10:18:50 2015 > New Revision: 395661 > URL: https://svnweb.freebsd.org/changeset/ports/395661 > > Log: > Drop USES=iconv. > > The port does not actually use iconv anywhere, so drop the dependency. While > here, also stop setting LDFLAGS since it is not necessary (as verified by > building on 9.3, 10.1 and HEAD). > I just want to point out that it's possible LDFLAGS=-L${LOCALBASE}/lib is still needed depending on the compiler. Some compilers may look there by default (thus LDFLAG not needed) but others may not. I'm not saying this commit is wrong, only that the justification "it builds on standard runs" can be dangerous thinking. LDFLAGS should be set if "-L" is not explicitly set, in general. Usually one of the USES tools will bring it in though. John
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?55E4310F.8090809>