From owner-freebsd-new-bus@FreeBSD.ORG Mon Nov 9 01:34:11 2009 Return-Path: Delivered-To: freebsd-new-bus@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CA3C8106566B; Mon, 9 Nov 2009 01:34:11 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 81BD88FC08; Mon, 9 Nov 2009 01:34:11 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.3/8.14.1) with ESMTP id nA91Pnxa066532; Sun, 8 Nov 2009 18:25:49 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Sun, 08 Nov 2009 18:25:56 -0700 (MST) Message-Id: <20091108.182556.1680365520.imp@bsdimp.com> To: attilio@freebsd.org From: "M. Warner Losh" In-Reply-To: <3bbf2fe10911080854x64d18e40hf639634e625dd11b@mail.gmail.com> References: <3bbf2fe10911080853qad0057w490694e5627681fe@mail.gmail.com> <3bbf2fe10911080854x64d18e40hf639634e625dd11b@mail.gmail.com> X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: freebsd-new-bus@freebsd.org, scottl@freebsd.org Subject: Re: [PATCH] Collapsing device_state_t with devinfo_state_t X-BeenThere: freebsd-new-bus@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: FreeBSD's new-bus architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Nov 2009 01:34:11 -0000 In message: <3bbf2fe10911080854x64d18e40hf639634e625dd11b@mail.gmail.com> Attilio Rao writes: : 2009/11/8 Attilio Rao : : > This patch should collpase device_state_t with devinfo_state_t and : > remove a bogus replication of this struct: : > http://www.freebsd.org/~attilio/devinfo.diff : : Sorry, forgot to mention: : I thought about adding _bus.h interface because I thought that : devinfo.h wanted to avoid a namespace pollution, but that's not really : the case as 85% of the bus.h is already under _KERNEL labels. That : means the pollution is minimal and restricted to 1-2 further structs. I'm cool with this patch, and that decision. Warner