From nobody Fri Apr 12 09:41:09 2024 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VGBQq0sp3z5H4T8; Fri, 12 Apr 2024 09:41:23 +0000 (UTC) (envelope-from makc@freebsd.org) Received: from mail.issp.ac.ru (mail.issp.ac.ru [77.236.34.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "relay.issp.ac.ru", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VGBQp663Fz4G7S; Fri, 12 Apr 2024 09:41:22 +0000 (UTC) (envelope-from makc@freebsd.org) Authentication-Results: mx1.freebsd.org; none Received: from mail-lf1-f47.google.com [209.85.167.47:60844] (HELO/EHLO mail-lf1-f47.google.com, authenticated with PLAIN) by mail.issp.ac.ru with ESMTPSA/inet id 43C9fLYl077338 (using TLSv1.2, with cipher ECDHE-RSA-AES128-GCM-SHA256 (128 bits), verified FAIL) Fri, 12 Apr 2024 12:41:21 +0300 (MSK) Received: by mail-lf1-f47.google.com with SMTP id 2adb3069b0e04-516f2e0edb7so872142e87.1; Fri, 12 Apr 2024 02:41:21 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCWQ3VptMs4AptHNDvKaf0nT0u5oCpovE+ZDHvns8yurKcdizXB/rc6DU4kNvSJ0Vha5ai0zt5JycRFI/hTylsVlDC5quuLc/i6il9K2kNOVVg10ij4jOsgk8CDDpLdw5w9v6X5VklYc9bw6zODG7/TCgp7kDWM= X-Gm-Message-State: AOJu0YywkqWevK07FB240XzDiF+yGAaw/A+9lv6JfKZsfthZ7g3ZrEc3 v9aM9xs05c2XMUGbCyxPS+tRlnz8vIu9BpeiR8DT71aRyr2f66JsGJPxNevKgMozYT6SEWNdWpZ YIbgfOH5CEhUaKqlSjbz2hfF9qOk= X-Google-Smtp-Source: AGHT+IEfifqQXqHX7zH7h4/Rvj6tn8t90W6EwdV2MIn5A004MHVFfASouE4qphNWMwXeFzRb+vc81Vuzb8YtwExzZFc= X-Received: by 2002:a19:8c0d:0:b0:516:a328:b080 with SMTP id o13-20020a198c0d000000b00516a328b080mr1389911lfd.1.1712914880964; Fri, 12 Apr 2024 02:41:20 -0700 (PDT) List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 References: <202404120607.43C674EB042318@gitrepo.freebsd.org> In-Reply-To: <202404120607.43C674EB042318@gitrepo.freebsd.org> From: Max Brazhnikov Date: Fri, 12 Apr 2024 12:41:09 +0300 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 0660187ad07f - main - cleanup: remove occurrences of WITH_DEBUG To: Mathieu Arnold Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:9113, ipnet:77.236.32.0/20, country:RU] X-Rspamd-Queue-Id: 4VGBQp663Fz4G7S I don't quite understand something about ports options and features. Can we have the same knob as an option and as a feature? For example, graphics/glaxnimate has DEBUG in the OPTIONS_DEFINE and the following lines in the Makefile: .if !${PORT_OPTIONS:MDEBUG} CXXFLAGS:= ${CXXFLAGS:C/-O([2-9]|[sz]|fast)/-O1/} -fstack-protector-strong -fno-strict-aliasing .endif Now to build this port in the debug mode I have to set WITH_DEBUG and enable DEBUG option at the same time. We should either disallow having DEBUG in the options and check only for WITH_DEBUG everywhere, or WITH_DEBUG feature should set DEBUG option automatically. Max