Date: Wed, 04 Apr 2007 12:03:51 +0200 From: Alex Dupre <ale@FreeBSD.org> To: Scott Long <scottl@samsco.org> Cc: freebsd-current@freebsd.org, freebsd-scsi@freebsd.org Subject: Re: targclose doesn't return Message-ID: <46137807.4060203@FreeBSD.org> In-Reply-To: <4612D49C.8040100@samsco.org> References: <46126585.8080204@FreeBSD.org> <46127DF4.5080703@samsco.org> <461285E0.8000008@FreeBSD.org> <7579f7fb0704031332o64d0637coe17770971d5a6e29@mail.gmail.com> <4612C873.1020505@samsco.org> <4612D49C.8040100@samsco.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Scott Long ha scritto: > Actually, I think it's a wildly incorrect use of the clone API. Hmm, I don't think scsi_target uses the clone API. Yes, probably it should or at least it will be better, but the problem will remain. From what I've understood we cannot call destroy_dev directly from d_close. The solutions I see are: - use the destroy_dev_sched function posted by Kostik - remove the device externally, after closing it (like other clonable devices already do) The latter approach probably needs some redesign of the scsi_target code, while the first should be simpler if it works as expected (perhaps we should handle in a different way an open() to a closed but not already destroyed device, dunno). > I'll > take a look at in the in next few days and try to commit something that > works. Thanks for your support. I'm available to help (as much as I'm able) and test patches. -- Alex Dupre
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?46137807.4060203>