From nobody Tue May 6 11:55:26 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZsGzy735pz5thlL; Tue, 06 May 2025 11:55:26 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZsGzy6Mm0z4Gyr; Tue, 06 May 2025 11:55:26 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1746532526; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=dWlaxWXeb4Re6BnzUP7ujD+zEotaF75EFhJfJW04DoA=; b=LXdXU6z/Jm94Vgrlw7KvMADe+RQwcBBtv7JlM+QiIeAqp7ilGN+IiJoe1Hl9AJfpBObkOy v0eTwcplpN0UbfB1/cwu7ozbPVOe6ewHN34Km30yIpJEUDWNYeAu1lxBiwk1NIOwReaxKv ZhiZj9OaFFN3SFWr7lfqxrw5/gzHQ+e322T5PzI450TzBDiPcnCTpP+idvOLGgmD3EQGrg p9bspFcTCf0e5+S5zPvmD7Ug2Ckp3aPpcCJbGGJ5CxxrW4HukCnqevp0y6lH3bF14uJedR 1aGfJoi5DC3NfNHKxXLaxpnk3hTwTOMdDPgObfF8zzI1CDsYGH/zus1wFfgupQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1746532526; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=dWlaxWXeb4Re6BnzUP7ujD+zEotaF75EFhJfJW04DoA=; b=gDQAd92f9ic2rCkBTrbnRAMn2O+0qwkG94uS6zxtX75N17BB0bn5pyj0OGw7sU5tYzNyH3 xPsQ7BeY5BANj1zd6//56SvMPvNPbmYA0CxwdxstB9Biwwnlfv71+CU4LpRc4o7/JgcBQI /0ycO7QcuXyV6zGQEoyOj/+0BTA0ORpRiZArK+F7isHXiabr72fhWMC8uBnNhTgisjz92A kW6Z9fGKubdPGUlwgb/iRR+nI0+DEf6c6Rmm4jZZzjTfAGM8fsY8raT490uqLHaLQd2PSV O3dX7hVowRGAh5HdRhg7vkTvvzmPW+AJbum1zDestF9fuizWUkHlNiZrw3M11g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1746532526; a=rsa-sha256; cv=none; b=l8qH+klBYdEz/32uUZWtc8najjnP3UIEHgWkWuCz/ASwM4DFMqBN6V9YvTIaB9XmG4lIVm Ymz+Hei9EJN7DBz2BYb2BoJt2/ZbqeIY93iM82p+IUQFF6Fn7fk+MuWoTc4Ag/7JIewO3r MygZ6i/5Iq0ZyJTssyXU5SbuQNWmDZIDEIbDhhtq5fPolXClqmX6Fdu9cYA6TH86KieG61 REhChluB9UDbDp9oqQfaWuUsCEMmxeczrJDFzUt1CYNVPL7mzkD3wrNB2YFdMMqh/ScpZd K63o6eXs8kMo281MJREm/q3rfSzh59SsPtOdZvz8ioL4LUlBKevGh7goQWK+Pw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4ZsGzy5NvYzyLq; Tue, 06 May 2025 11:55:26 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 546BtQb2087233; Tue, 6 May 2025 11:55:26 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 546BtQtr087230; Tue, 6 May 2025 11:55:26 GMT (envelope-from git) Date: Tue, 6 May 2025 11:55:26 GMT Message-Id: <202505061155.546BtQtr087230@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Corvin =?utf-8?Q?K=C3=B6hne?= Subject: git: 691833ad3776 - main - sys/intpm: fix SMBus Read Block List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: corvink X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 691833ad3776c17ba3267049ac36bc3461c66799 Auto-Submitted: auto-generated The branch main has been updated by corvink: URL: https://cgit.FreeBSD.org/src/commit/?id=691833ad3776c17ba3267049ac36bc3461c66799 commit 691833ad3776c17ba3267049ac36bc3461c66799 Author: Corvin Köhne AuthorDate: 2025-05-05 09:23:18 +0000 Commit: Corvin Köhne CommitDate: 2025-05-06 11:54:18 +0000 sys/intpm: fix SMBus Read Block The Read Block function missed saving the data into the preallocated buffer. This causes it to return some garbage when called. Reviewed by: avg MFC after: 1 week Sponsored by: Beckhoff Automation GmbH & Co. KG Pull Request: https://github.com/freebsd/freebsd-src/pull/1691 --- sys/dev/intpm/intpm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/intpm/intpm.c b/sys/dev/intpm/intpm.c index 2f12e0dcf49b..fd3838bbcc14 100644 --- a/sys/dev/intpm/intpm.c +++ b/sys/dev/intpm/intpm.c @@ -879,7 +879,7 @@ intsmb_bread(device_t dev, u_char slave, char cmd, u_char *count, char *buf) if (nread != 0 && nread <= SMBBLOCKTRANS_MAX) { *count = nread; for (i = 0; i < nread; i++) - bus_read_1(sc->io_res, PIIX4_SMBBLKDAT); + buf[i] = bus_read_1(sc->io_res, PIIX4_SMBBLKDAT); } else error = SMB_EBUSERR; }