From owner-freebsd-rc@FreeBSD.ORG Wed Jul 16 20:06:11 2008 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 54C4B1065671 for ; Wed, 16 Jul 2008 20:06:11 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx23.fluidhosting.com [204.14.89.6]) by mx1.freebsd.org (Postfix) with ESMTP id 0425D8FC23 for ; Wed, 16 Jul 2008 20:06:10 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: (qmail 15619 invoked by uid 399); 16 Jul 2008 20:06:10 -0000 Received: from localhost (HELO lap.dougb.net) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTPAM; 16 Jul 2008 20:06:10 -0000 X-Originating-IP: 127.0.0.1 X-Sender: dougb@dougbarton.us Message-ID: <487E54B1.4070407@FreeBSD.org> Date: Wed, 16 Jul 2008 13:06:09 -0700 From: Doug Barton Organization: http://www.FreeBSD.org/ User-Agent: Thunderbird 2.0.0.14 (X11/20080606) MIME-Version: 1.0 To: freebsd-rc@freebsd.org References: <487E533F.7050303@FreeBSD.org> In-Reply-To: <487E533F.7050303@FreeBSD.org> X-Enigmail-Version: 0.95.6 OpenPGP: id=D5B2F0FB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: Heads Up: shutdown keyword added to 34 rc.d scripts. X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Jul 2008 20:06:11 -0000 One more followup, des had asked to have "faststop" in rc.shutdown changed to just "stop," and initially I had no objection to that change. However looking at it more closely, the only difference is this: if [ -z "$rc_pid" ]; then [ -n "$rc_fast" ] && return 0 _run_rc_notrunning return 1 fi The _run_rc_notrunning function is what prints the "${name} not running?" message, which I don't think it would be useful to do when shutting the system down. Doug Doug Barton wrote: > FYI. If you are familiar with kerberos stuff and want to add shutdown > there, please feel free. Same goes with the network stuff if you feel > strongly it should be added. > > By the same token, if adding shutdown breaks something please feel > free to revert it. The only thing I ask is that you clarify the > reasons in the commit message for posterity. > > I've run with this locally for quite a while and just haven't had a > chance to commit it. OTOH I don't use most of the stuff covered by > this, so I'd like to get it tested in real world conditions for a > while before it's MFC'ed. > > > Regards, > > Doug > > -------- Original Message -------- > Subject: svn commit: r180564 - head/etc/rc.d > Date: Wed, 16 Jul 2008 19:50:29 +0000 (UTC) > From: Doug Barton > To: src-committers@freebsd.org > > Author: dougb > Date: Wed Jul 16 19:50:29 2008 > New Revision: 180564 > URL: http://svn.freebsd.org/changeset/base/180564 > > Log: > ~ Add the shutdown KEYWORD to those scripts that start persistent > ~ services to allow them to do a "clean" shutdown. > > ~ I purposely avoided making changes to network-related stuff since > ~ the system shutting down is pretty conclusive, and there may be > ~ complicated dependencies on the network that I would rather not try > ~ to unravel. > > ~ I also skipped kerberos-related stuff for the reasons above, and > ~ because I have no way to test it. -- This .signature sanitized for your protection