From nobody Thu Sep 1 16:42:17 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MJRfL0PdRz4Ztwv; Thu, 1 Sep 2022 16:42:18 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MJRfK72qvz3PKp; Thu, 1 Sep 2022 16:42:17 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1662050538; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=4vZxvaCjCXD3gOZV0YwFxq+hT8so5ewBFPJB8WJcWVs=; b=wGB6CaDM0Uc4bZImFm915DcSRzkhr1NZVle3FwzCNKKOawoVG1mJ7bGPp4c8uw0jQirTzc bzh3+XM/pQWhzsKc40kpepkU1bjM3LwnPkosf7ntA2XWiH2sOQ6uQp5PEiu2fWAQ59mU2i mCqwCIPBPlGu6RimO01NOGBkwj2pIcCxB8dfLXIVQvEYDoZ7d24QP0C0Q/PQVJ9WlpTt3C 4754x10UBJ/Ed1BPMeptH1hSRuqVfsol/BPBBGDJl7L1PCoj09ocSnsVB/DEsPURXc4M+f TjwJVmiomTzHseVTh5qenXlLcCSfH2CYNRqrPe6aPyTVzqrf6LJQ7bpdTxW6mw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4MJRfK65sNzXMX; Thu, 1 Sep 2022 16:42:17 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 281GgHj5067599; Thu, 1 Sep 2022 16:42:17 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 281GgH3u067598; Thu, 1 Sep 2022 16:42:17 GMT (envelope-from git) Date: Thu, 1 Sep 2022 16:42:17 GMT Message-Id: <202209011642.281GgH3u067598@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Warner Losh Subject: git: b1819983e70f - main - stand: Stop setting hints for bios loader too List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: b1819983e70f5b8890404b7e07d17888d0cccfb6 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1662050538; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=4vZxvaCjCXD3gOZV0YwFxq+hT8so5ewBFPJB8WJcWVs=; b=oIITZwB/Q+8gbk4yhyyi49q0hF/8aM+5aF4EzCsrVyK8U90dfcgw7hpHZ8EXjEhTwJggNf 2n1XtfDtxHhKkxWBDxDqDPZWd4PwgJBDycGA+dWwhpmBocRj4QtQqNlzixj6GzfRTiiAyw R8RYWa631EdGof8ob1l8lWllmTLoBo/LYNdPqayLvOP/JvvzgLFUD/tZod0ZhvsOEZlXg8 mEnquscnX+Y9dHlGeq7HC5IiO6mMuZLi1+u8DSa0nY56ad2ZAgLCM8cRCz71QqfXlyiYqe 8rGy9RRSKQ949gJeKD2kRNadULOHw1jBbCTQs9C5snjIYwAx2RFOr4YxxJWCWA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1662050538; a=rsa-sha256; cv=none; b=KTzTDWY1m4Iwq1UflGJzeK0DdqJDVjwZVWdzNl+aE7T5WN633dWfUgkE1sjz62onzZHOa3 nkA1wqruIrIFZzI+xaTp6zHKztSBCUytHYmNY9Pd0r2UeZ5HHC2ktDC8QFOT/TPGBppTnL nEDrqbr2gQ+VVjywt2JcSWsMxb1c7fjQKT7bAduGLwJQ2wdmp5BEUh93/Ezo9UUaNcqxgi GkTA83DAzXIdYT6rEcmz2apyXAurGBQ7M4SpX92Xd1s0fyf3Zw4KoemzoEesJBol/b9NWn SQETHR1+71TouZwIupR7jLQIhTJXPvO40wJ6Gl3JasKX0bCB+v73lcU6Bg721w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=b1819983e70f5b8890404b7e07d17888d0cccfb6 commit b1819983e70f5b8890404b7e07d17888d0cccfb6 Author: Warner Losh AuthorDate: 2022-09-01 16:33:09 +0000 Commit: Warner Losh CommitDate: 2022-09-01 16:33:09 +0000 stand: Stop setting hints for bios loader too Catch up to 2753bbe71b5a and remove the old hints. Sponsored by: Netflix --- stand/i386/libi386/biosacpi.c | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/stand/i386/libi386/biosacpi.c b/stand/i386/libi386/biosacpi.c index 236c3fc45e7b..3bda472f3fc6 100644 --- a/stand/i386/libi386/biosacpi.c +++ b/stand/i386/libi386/biosacpi.c @@ -63,36 +63,24 @@ biosacpi_detect(void) /* * Report the RSDP to the kernel. While this can be found with * a BIOS boot, the RSDP may be elsewhere when booted from UEFI. - * The old code used the 'hints' method to communite this to - * the kernel. However, while convenient, the 'hints' method - * is fragile and does not work when static hints are compiled - * into the kernel. Instead, move to setting different tunables - * that start with acpi. The old 'hints' can be removed before - * we branch for FreeBSD 12. */ sprintf(buf, "0x%08x", VTOP(rsdp)); - setenv("hint.acpi.0.rsdp", buf, 1); setenv("acpi.rsdp", buf, 1); revision = rsdp->Revision; if (revision == 0) revision = 1; sprintf(buf, "%d", revision); - setenv("hint.acpi.0.revision", buf, 1); setenv("acpi.revision", buf, 1); strncpy(buf, rsdp->OemId, sizeof(rsdp->OemId)); buf[sizeof(rsdp->OemId)] = '\0'; - setenv("hint.acpi.0.oem", buf, 1); setenv("acpi.oem", buf, 1); sprintf(buf, "0x%08x", rsdp->RsdtPhysicalAddress); - setenv("hint.acpi.0.rsdt", buf, 1); setenv("acpi.rsdt", buf, 1); if (revision >= 2) { /* XXX extended checksum? */ sprintf(buf, "0x%016llx", rsdp->XsdtPhysicalAddress); - setenv("hint.acpi.0.xsdt", buf, 1); setenv("acpi.xsdt", buf, 1); sprintf(buf, "%d", rsdp->Length); - setenv("hint.acpi.0.xsdt_length", buf, 1); setenv("acpi.xsdt_length", buf, 1); } }