From owner-svn-ports-head@freebsd.org Mon Apr 18 19:20:08 2016 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 31E95B13B26; Mon, 18 Apr 2016 19:20:08 +0000 (UTC) (envelope-from ohauer@gmx.de) Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mout.gmx.net", Issuer "TeleSec ServerPass DE-1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8AFA611B2; Mon, 18 Apr 2016 19:20:06 +0000 (UTC) (envelope-from ohauer@gmx.de) Received: from [192.168.100.100] ([87.139.233.65]) by mail.gmx.com (mrgmx103) with ESMTPSA (Nemesis) id 0MhQju-1b62CS45Du-00Mcjq; Mon, 18 Apr 2016 21:19:59 +0200 Subject: Re: svn commit: r413604 - in head/Mk: . Scripts To: Mathieu Arnold , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <201604181839.u3IIdjhn065995@repo.freebsd.org> From: olli hauer Message-ID: <57153497.5000000@gmx.de> Date: Mon, 18 Apr 2016 21:25:11 +0200 User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <201604181839.u3IIdjhn065995@repo.freebsd.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:9CspwE4uvGClzs1HWBL5APD/k6sT7R9lcnft1r+V6K01+dS76Jt XkeLjOHqT1X6tqENDddwaauICLP8tcQ3d2gyHwFJ+wVRvvuZBxYETfC5DnwD6vStWOPJtxA /MwVtDuVqEzt9LeHN+KJG7DmavMCHey/Plq4b5zYbS10WC6RTHwZRd0O9xaKC/ZUxR+8MYV NrmMg+6y70xkrnp9pYb6g== X-UI-Out-Filterresults: notjunk:1;V01:K0:6L4sfLNViTQ=:ht2cYdzKyUw66HXlxuEQbu 7hf9hzN1tOhPh31Q6LJ6uYK3m7mSw+iXFccLsM2illVermwEygzqaTS7eP0cro1vwu3O07Wcb +egHPn61kn6ZWyp1g0ZW5IBxVoPnKLxrvqZkikdb0pzLJcJU7BCPOYTsrZdP8hVbLJB/84gqN lkVFQWSV59PRpvwJG529imftPjUE70YkG1I7OqGhzaUt5YcZvOXH25utOLPkkiqCsufLixYUp ZOh/cwYdbSjOvux4J5gHq2nTsYAvCbAm8wjLELjmPeCdUNs5vkQfV/lyZrbVJdwPHb2xO9Zs1 bcKTv0LSZm8HsclxAiv5g0Ux3NlHWJKa6oy0BRMRsD5wAG/fxRj3rYMBgOo04r82VadHKLEPV 53NFyGL0fQWL3pU70kbL/tG7bD5yRmxSaV8sbkxjyIT75I3eUPGSvvVfPZw44PvwL7db38Bvi d5kWR6qEY7rBfENg0oyMTGRaN8mHLi4FILbcI78B9FgaWd7qmtDuhJ9nmym6O6gN23lVPn7u5 HrVthDQo7bRq9XOibVvQlmUZaIdCh93MXlv68JYPVUdAKTY3LUXd/9qb+xs2BbIAiJ2SdUOXg 9tlokBat2P8GCbaawJnduBx1lZMOUzo2J75pxhPe4jfPXhumakRT492fwnu/xeL0+3s4X4PHy jBqMiyudLuxHfVTFHaA4iIVh9Q6KgSpsa2JQ+BnOx2G4QTHEATTkc5Yc3P88v7//gZ39HOVs3 xPADve7KohoFTHemFk2Ob60AO3rgZ1Uuwh8ZWlNVF4uDdzS0UzI9Q52PyHzPFzjfRk7SsuBrW lLaLXYp X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Apr 2016 19:20:08 -0000 On 2016-04-18 20:39, Mathieu Arnold wrote: > Author: mat > Date: Mon Apr 18 18:39:44 2016 > New Revision: 413604 > URL: https://svnweb.freebsd.org/changeset/ports/413604 > > Log: > Extract the users/groups creation into a separate shell script. > > This adds a few features: > - it checks that the UID line has the right number of fields [1] > - it tells the user that there are groups that he may want to remove [2] > > PR: 208800, 173318 [1], 157546 [2] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=208800 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=208800 > Submitted by: mat > Sponsored by: Absolight > Differential Revision: https://reviews.freebsd.org/D5939 > ... > Modified: head/Mk/bsd.port.mk > ============================================================================== > --- head/Mk/bsd.port.mk Mon Apr 18 18:17:19 2016 (r413603) > +++ head/Mk/bsd.port.mk Mon Apr 18 18:39:44 2016 (r413604) > @@ -1245,6 +1245,10 @@ GID_OFFSET?= 0 > # alpha numeric sort order > USERS_BLACKLIST= _dhcp _pflogd auditdistd bin bind daemon games hast kmem mailnull man news nobody operator pop proxy root smmsp sshd toor tty uucp www > > +# predefined accounts from src/etc/group > +# alpha numeric sort order > +GROUPS_BLACKLIST= _dhcp _pflogd audit authpf bin bind daemon dialer ftp games guest hast kmem mail mailnull man network news nobody nogroup operator proxy smmsp sshd staff sys tty unbound uucp wheel www ... Hi Mathieu, nice rework :) I've done a quick compare of the USERS_BLACKLIST and /etc/ftpusers on a 10.x system and noted "unbound" is missing in both BLACKLISTS. Would you mind to extend the BLACKLIST's? -- olli