From owner-freebsd-ports@FreeBSD.ORG  Mon Feb 25 02:49:04 2008
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 551EE16A407;
	Mon, 25 Feb 2008 02:49:04 +0000 (UTC) (envelope-from des@des.no)
Received: from tim.des.no (tim.des.no [194.63.250.121])
	by mx1.freebsd.org (Postfix) with ESMTP id 300C213C4E1;
	Mon, 25 Feb 2008 02:49:04 +0000 (UTC) (envelope-from des@des.no)
Received: from tim.des.no (localhost [127.0.0.1])
	by spam.des.no (Postfix) with ESMTP id C716E2085;
	Mon, 25 Feb 2008 03:32:47 +0100 (CET)
X-Spam-Tests: AWL,URIBL_OB_SURBL
X-Spam-Learn: disabled
X-Spam-Score: 0.8/3.0
X-Spam-Checker-Version: SpamAssassin 3.2.4 (2008-01-01) on tim.des.no
Received: from ds4.des.no (des.no [80.203.243.180])
	by smtp.des.no (Postfix) with ESMTP id 544E72084;
	Mon, 25 Feb 2008 03:32:47 +0100 (CET)
From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no>
To: perl@freebsd.org, ports@freebsd.org
Date: Mon, 25 Feb 2008 03:32:46 +0100
Message-ID: <86zltpzrxt.fsf@ds4.des.no>
User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/23.0.60 (berkeley-unix)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: 
Subject: Port dependencies on p5-Test-*
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 25 Feb 2008 02:49:04 -0000

There is a ridiculous amount of p5-* ports that have completely
unnecessary build dependencies on p5-Test-*.  These package are usually
only needed to run unit tests (cd ${WRKSRC} && make test), which *none*
of those ports do.

(ridiculous, in this case, means close to 300)

What's worse, most of these ports have RUN_DEPENDS =3D ${BUILD_DEPENDS},
which means even the prebuilt packages have these unnecessary
dependencies!

All of this could be avoided by adding these few lines to the port's
Makefile, and removing p5-Test-* from BUILD_DEPENDS:

pre-configure:
        @(cd ${WRKSRC} && ${REINPLACE_CMD} -E -e \
            "s/'?Test::[^']+'?[[:space:]]*=3D>[[:space:]]'?[0-9.]+'?,//" \
            Makefile.PL)

(some ports also need to edit Build.PL)

Alternatively, this could be added to bsd.perl.mk, conditional on the
presence of a PERL_UNTESTIFY_FILES variable which would list Makefile.PL
and / or Build.PL for the ports that require it.

DES
--=20
Dag-Erling Sm=C3=B8rgrav - des@des.no