From owner-freebsd-office@freebsd.org Fri Mar 4 11:50:21 2016 Return-Path: Delivered-To: freebsd-office@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 44F069DA0C3 for ; Fri, 4 Mar 2016 11:50:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 2F2881FA for ; Fri, 4 Mar 2016 11:50:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 2BD069DA0C2; Fri, 4 Mar 2016 11:50:21 +0000 (UTC) Delivered-To: office@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2B44B9DA0C1 for ; Fri, 4 Mar 2016 11:50:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1AF1C1F9 for ; Fri, 4 Mar 2016 11:50:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u24BoKsn088410 for ; Fri, 4 Mar 2016 11:50:20 GMT (envelope-from bugzilla-noreply@freebsd.org) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" From: bugzilla-noreply@freebsd.org To: office@FreeBSD.org Subject: maintainer-feedback requested: [Bug 207697] editors/libreoffice4: fix build with boost 1.60 Date: Fri, 04 Mar 2016 11:50:20 +0000 X-Bugzilla-Type: request X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: needs-qa, patch X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: office@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? Message-ID: In-Reply-To: References: X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-office@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Office applications on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Mar 2016 11:50:21 -0000 Don Lewis has reassigned Bugzilla Automation 's request for maintainer-feedback to office@FreeBSD.= org: Bug 207697: editors/libreoffice4: fix build with boost 1.60 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D207697 --- Description --- Created attachment 167709 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D167709&action= =3Dedit patch to unbreak editors/libreoffice4 when building with boost 1.60 The libreoffice4 build fails if the boost port is upgraded to version 1.60.= =20 The attached patch contains two sets of changes to fix this problem. The f= irst part is the upstream commit 45dfbdca6a9afba1a6aef21623ec025ded635a4d. The other part is a small fragment of the upstream commit e00a3a684e22f45f36b4002ce726cb2975cb36ae to add -DBOOST_ERROR_CODE_HEADER_O= NLY and -DBOOST_SYSTEM_NO_DEPRECATED to the compiler flags. The upstream commit 45dfbdca6a9afba1a6aef21623ec025ded635a4d works with both boost 1.60 as well as the current in-tree boost 1.55. Unfortunately the ot= her change is not compatible with boost 1.55 for unknown reasons. Without this second change, the build with boost 1.60 fails with this error: [build LNK] StaticLibrary/libwriterperfect_importtestbase.a /wrkdirs/usr/ports/editors/libreoffice4/work/libreoffice-4.3.7.2/workdir/Li= nkTa rget/StaticLibrary/libpdfimport_s.a(pdfparse.o): In function `global constructors keyed to a': /wrkdirs/usr/ports/editors/libreoffice4/work/libreoffice-4.3.7.2/sdext/sour= ce/p dfimport/pdfparse/pdfparse.cxx:(.text+0x34c): undefined reference to `boost::system::generic_category()' /wrkdirs/usr/ports/editors/libreoffice4/work/libreoffice-4.3.7.2/sdext/sour= ce/p dfimport/pdfparse/pdfparse.cxx:(.text+0x358): undefined reference to `boost::system::generic_category()' /wrkdirs/usr/ports/editors/libreoffice4/work/libreoffice-4.3.7.2/sdext/sour= ce/p dfimport/pdfparse/pdfparse.cxx:(.text+0x364): undefined reference to `boost::system::system_category()' c++: error: linker command failed with exit code 1 (use -v to see invocatio= n) /wrkdirs/usr/ports/editors/libreoffice4/work/libreoffice-4.3.7.2/solenv/gbu= ild/ LinkTarget.mk:444: recipe for target '/wrkdirs/usr/ports/editors/libreoffice4/work/libreoffice-4.3.7.2/workdir/L= inkT arget/Executable/pdfunzip' failed gmake[2]: *** [/wrkdirs/usr/ports/editors/libreoffice4/work/libreoffice-4.3.7.2/workdir/L= inkT arget/Executable/pdfunzip] Error 1 With this second change, the build with boost 1.59 fails with this error: In file included from /wrkdirs/usr/ports/editors/libreoffice4/work/libreoffice-4.3.7.2/sc/qa/unit= /hel per/qahelper.cxx:10: In file included from /wrkdirs/usr/ports/editors/libreoffice4/work/libreoffice-4.3.7.2/sc/qa/unit= /hel per/qahelper.hxx:14: In file included from /wrkdirs/usr/ports/editors/libreoffice4/work/libreoffice-4.3.7.2/sc/qa/unit= /hel per/debughelper.hxx:27: In file included from /usr/local/include/mdds/mixed_type_matrix.hpp:33: In file included from /usr/local/include/mdds/mixed_type_matrix_storage.hpp= :39: In file included from /usr/local/include/boost/pool/object_pool.hpp:18: In file included from /usr/local/include/boost/pool/poolfwd.hpp:24: In file included from /usr/local/include/boost/pool/detail/mutex.hpp:14: In file included from /usr/local/include/boost/thread/mutex.hpp:16: In file included from /usr/local/include/boost/thread/pthread/mutex.hpp:12: In file included from /usr/local/include/boost/thread/exceptions.hpp:22: In file included from /usr/local/include/boost/system/system_error.hpp:14: /usr/local/include/boost/system/error_code.hpp:516:13: fatal error: 'boost/../libs/system/src/error_code.cpp' file not found # include ^ The problem is that error_code.hpp contains: # ifdef BOOST_ERROR_CODE_HEADER_ONLY # include # endif and error_code.cpp is not installed. I think this was fixed in boost 1.56.= 0. For some unknown reason, editors/libreoffice which uses -DBOOST_ERROR_CODE_HEADER_ONLY and -DBOOST_SYSTEM_NO_DEPRECATED does not su= ffer this same fate. Unfortunately I also haven't been able to think of a clean way of detecting= the boost version and tweaking the use of these flags to DTRT.