Date: Thu, 30 May 1996 13:03:50 -0700 (PDT) From: asami@cs.berkeley.edu (Satoshi Asami) To: jkh@time.cdrom.com Cc: ports@freebsd.org Subject: Re: Request for feedback: REQUIRES_OS_VERSION feature. Message-ID: <199605302003.NAA03290@silvia.HIP.Berkeley.EDU> In-Reply-To: <20695.833472415@time.cdrom.com> (jkh@time.cdrom.com)
next in thread | previous in thread | raw e-mail | index | archive | help
* > First, disabling reinstall based on NO_INSTALL is not necessary, as
* > reinstall calls install and that will be disabled by NO_INSTALL.
*
* I know, I just did that for orthogonality with the package and
* repackage rules - think of it as an optimization. :-)
Oops...that's a brain-o on my part. Let's remove the disabling of the
repackage rule too, it's not much of an optimization and anything that
makes that spaghetti from hell shorter is a good thing anyways. ;]
* I know, this was all of 10 minutes work here and I took the path of
* least resistance (this was the implementation of an _idea_, not so
* much the final implementation of whatever we adopt - that's why I
* posted it here rather than simply commit it). If you can come up
* with a better way of causing ports who's checks fail to skip
* absolutely everything, that'll be fine by me.
Ok.
* While you're in there, why not add an option to make clean's "chain"
* to dependent ports? It's always annoyed me that you can do a build in
* port A and have it build ports B, C and D as part of the dependencies
* but when you then do a make clean from A you still wind up with B, C &
* D fully populated. Basically, the clean target is next to useless
* unless you always run it from the top right now.
That's a very good idea. I'll look into this tonight.
* Find with me! Just so long as it's not a fatal error to fail the
* check.
Yeah, we should find a way to make it either fatal or non-fatal, and
also take the output from a command (uname). That's the hard part.
Can we somehow get the OS version in a make variable?
Satoshi
P.S. Meanwhile, this is the non-controversial part of your cleanup,
does it look ok?
=======
--- bsd.port.mk Thu May 30 02:18:12 1996
+++ /usr/share/mk/bsd.port.mk Thu May 30 12:56:17 1996
@@ -464,7 +472,6 @@
DEPENDS="${DEPENDS}" BUILD_DEPENDS="${BUILD_DEPENDS}" \
RUN_DEPENDS="${RUN_DEPENDS}" X11BASE=${X11BASE} \
${ALL_HOOK}
-
.endif
.if !target(all)
@@ -488,6 +495,7 @@
# override from an individual Makefile.
################################################################
+# Disable extract
.if defined(NO_EXTRACT) && !target(extract)
extract: checksum
@${TOUCH} ${TOUCH_FLAGS} ${EXTRACT_COOKIE}
@@ -496,26 +504,32 @@
makesum:
@${DO_NADA}
.endif
+
+# Disable configure
.if defined(NO_CONFIGURE) && !target(configure)
configure: patch
@${TOUCH} ${TOUCH_FLAGS} ${CONFIGURE_COOKIE}
.endif
+
+# Disable build
.if defined(NO_BUILD) && !target(build)
build: configure
@${TOUCH} ${TOUCH_FLAGS} ${BUILD_COOKIE}
.endif
+
+# Disable package
.if defined(NO_PACKAGE) && !target(package)
package:
@${DO_NADA}
.endif
-.if defined(NO_PACKAGE) && !target(repackage)
-repackage:
- @${DO_NADA}
-.endif
+
+# Disable install
.if defined(NO_INSTALL) && !target(install)
install: build
@${TOUCH} ${TOUCH_FLAGS} ${INSTALL_COOKIE}
.endif
+
+# Disable patch
.if defined(NO_PATCH) && !target(patch)
patch: extract
@${TOUCH} ${TOUCH_FLAGS} ${PATCH_COOKIE}
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199605302003.NAA03290>