Date: Thu, 10 Aug 2006 13:00:09 -0700 (PDT) From: "R. B. Riddick" <arne_woerner@yahoo.com> To: Craig Boston <craig@xfoil.gank.org>, Eric Anderson <anderson@centtech.com> Cc: freebsd-fs@FreeBSD.org, Pawel Jakub Dawidek <pjd@FreeBSD.org>, freebsd-geom@FreeBSD.org Subject: Re: GJournal (hopefully) final patches. Message-ID: <20060810200009.98202.qmail@web30306.mail.mud.yahoo.com> In-Reply-To: <20060810191908.GA32326@nowhere>
next in thread | previous in thread | raw e-mail | index | archive | help
--- Craig Boston <craig@xfoil.gank.org> wrote:
> sbin/geom/class/journal/geom_journal.c:
>
> if (jsize == -1) {
> /*
> * No journal size specified. 1GB should be safe
> * default.
> */
> jsize = 1073741824ULL;
> }
> msize = g_get_mediasize(data);
> ssize = g_get_sectorsize(data);
> if (jsize + ssize >= msize) {
> gctl_error(req, "Provider too small for journalling.
> "
> "You can try smaller jsize (default is %jd).",
> jsize);
> return;
>
The gctl_error message shall be rewritten:
It should be:
"You can try smaller journal size (%jd too large).",
since "default" implies for me 1GB, while it might well be, that somebody chose
10GB.
-Arne
---
2*2=5
__________________________________________________
Do You Yahoo!?
Tired of spam? Yahoo! Mail has the best spam protection around
http://mail.yahoo.com
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060810200009.98202.qmail>